Page MenuHomePhabricator

Only fire notifications for new comments when signature matches current user
Closed, ResolvedPublic

Description

Pros:

  • No notifications when moving or re-ordering comments
  • No notifications when a user spoofs another user (e.g. "User:Trusted has asked you to visit <malicious URL>")

Cons:

  • No notifications when signatures added later by another user, e.g. User:SineBot

Event Timeline

Change 681659 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] EventDispatcher: Only generate events if author matches user

https://gerrit.wikimedia.org/r/681659

Change 681659 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] EventDispatcher: Only generate events if author matches user

https://gerrit.wikimedia.org/r/681659