Maniphest T280811

Move WikibaseRepo EntityRevisionLookupFactoryCallbacks to service container
Closed, ResolvedPublic
Actions

Assigned To

Lucas_Werkmeister_WMDE

Authored By

	Lucas_Werkmeister_WMDE
	Apr 21 2021, 3:56 PM

Tags

Referenced Files

None

Subscribers

Lucas_Werkmeister_WMDE

Description

Or just inline them, since they’re only called in one place as far as I can tell.

Details

	Subject	Repo	Branch	Lines +/-
	Remove WikibaseRepo::getEntityRevisionLookupFactoryCallbacks()	mediawiki/extensions/Wikibase	master	+3 -8

Customize query in gerrit

Related Objects

Mentioned In: T268600: Implement services through MediaWikiServices
T280815: Move WikibaseRepo EntityStoreFactoryCallbacks to service container

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 21 2021, 3:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 3:56 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 21 2021, 3:57 PM

Lucas_Werkmeister_WMDE mentioned this in T280815: Move WikibaseRepo EntityStoreFactoryCallbacks to service container.Apr 21 2021, 4:01 PM

Lucas_Werkmeister_WMDE claimed this task.Apr 21 2021, 4:11 PM

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 681710 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo::getEntityRevisionLookupFactoryCallbacks()

https://gerrit.wikimedia.org/r/681710

gerritbot added a project: Patch-For-Review.Apr 21 2021, 4:14 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 21 2021, 4:14 PM

Change 681710 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo::getEntityRevisionLookupFactoryCallbacks()

https://gerrit.wikimedia.org/r/681710

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 21 2021, 10:48 PM

Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 21 2021, 10:50 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 11:10 PM