Page MenuHomePhabricator
Create Task
Maniphest T280814

Move WikibaseRepo ItemRedirectCreationInteractor to service container
Closed, ResolvedPublic
Actions

Description

This service takes a Context, so this will be a trickier migration. I suspect we’ll want to add a context argument to EntityRedirectCreationInteractor::createRedirect() so that we can remove it from the constructor.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+3 -3Restore typehinting after removal of compatibility code
mediawiki/extensions/WikibaseLexememaster+6 -2Pass $context into createRedirect method instead of parent constructor
mediawiki/extensions/Wikibasemaster+115 -76Move WikibaseRepo ItemRedirectCreationInteractor to service container
mediawiki/extensions/Wikibasemaster+69 -98Pass IContextSource directly into createRedirect()...
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 21 2021, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 4:00 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 21 2021, 4:00 PM
Lucas_Werkmeister_WMDE mentioned this in T280817: Move WikibaseRepo ItemMergeInteractor to service container.Apr 21 2021, 4:03 PM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 21 2021, 10:50 PM
ItamarWMDE claimed this task.Apr 22 2021, 6:41 AM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 22 2021, 9:09 AM

Change 681939 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Pass IContextSource directly into createRedirect()

https://gerrit.wikimedia.org/r/681939

gerritbot added a project: Patch-For-Review.Apr 22 2021, 9:09 AM
gerritbot added a comment.Apr 22 2021, 12:05 PM

Change 681948 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Pass $context into createRedirect method instead of parent constructor

https://gerrit.wikimedia.org/r/681948

gerritbot added a comment.Apr 22 2021, 3:40 PM

Change 681995 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo ItemRedirectCreationInteractor to service container

https://gerrit.wikimedia.org/r/681995

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 22 2021, 3:44 PM
ItamarWMDE mentioned this in T280959: WikibaseRepo: Introduce TokenCheckInteractor service.Apr 23 2021, 7:55 AM
gerritbot added a comment.Apr 23 2021, 12:34 PM

Change 682121 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Restore typehinting after removal of compatibility code

https://gerrit.wikimedia.org/r/682121

gerritbot added a comment.Apr 23 2021, 2:12 PM

Change 681939 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Pass IContextSource directly into createRedirect()...

https://gerrit.wikimedia.org/r/681939

gerritbot added a comment.Apr 23 2021, 2:13 PM

Change 681948 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Pass $context into createRedirect method instead of parent constructor

https://gerrit.wikimedia.org/r/681948

gerritbot added a comment.Apr 23 2021, 2:13 PM

Change 681995 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo ItemRedirectCreationInteractor to service container

https://gerrit.wikimedia.org/r/681995

gerritbot added a comment.Apr 23 2021, 2:29 PM

Change 682121 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Restore typehinting after removal of compatibility code

https://gerrit.wikimedia.org/r/682121

ItamarWMDE closed this task as Resolved.Apr 23 2021, 2:59 PM
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 23 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 23 2021, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL