Move WikibaseRepo ItemMergeInteractor to service container
Closed, ResolvedPublic
Actions

Description

This depends on T280814: Move WikibaseRepo ItemRedirectCreationInteractor to service container, and the outcome will depend on how we deal with the context argument in that task.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Wikibase	master	+1 -1	Make WikibaseRepo::getItemMergeInteractor() static
mediawiki/extensions/Wikibase	master	+113 -54	Move WikibaseRepo ItemMergeInteractor to service container
mediawiki/extensions/Wikibase	master	+39 -66	Ensure context paramter is required in mergeItems

Customize query in gerrit

Related Objects

Mentioned In: T280984: WikibaseRepo: Remove getDefaultInstance()
T280959: WikibaseRepo: Introduce TokenCheckInteractor service
T268600: Implement services through MediaWikiServices
Mentioned Here: T280814: Move WikibaseRepo ItemRedirectCreationInteractor to service container

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 21 2021, 4:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 4:03 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 21 2021, 4:03 PM

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Waiting for other services on the Wikibase Service Migration board.

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 21 2021, 10:50 PM

ItamarWMDE claimed this task.Apr 22 2021, 4:52 PM

ItamarWMDE moved this task from Waiting for other services to Doing on the Wikibase Service Migration board.

ItamarWMDE mentioned this in T280959: WikibaseRepo: Introduce TokenCheckInteractor service.Apr 23 2021, 7:55 AM

Change 682089 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Ensure context paramter is required in mergItems

https://gerrit.wikimedia.org/r/682089

gerritbot added a project: Patch-For-Review.Apr 23 2021, 8:00 AM

Change 682133 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo ItemMergeInteractor to service container

https://gerrit.wikimedia.org/r/682133

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 23 2021, 2:03 PM

ItamarWMDE mentioned this in T280984: WikibaseRepo: Remove getDefaultInstance().Apr 23 2021, 3:35 PM

Change 682089 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Ensure context paramter is required in mergeItems

https://gerrit.wikimedia.org/r/682089

Change 682133 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo ItemMergeInteractor to service container

https://gerrit.wikimedia.org/r/682133

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2021, 8:10 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 23 2021, 11:00 PM

Rosalie_WMDE closed this task as Resolved.Apr 26 2021, 6:24 AM

Rosalie_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

Change 682568 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Make WikibaseRepo::getItemMergeInteractor() static

https://gerrit.wikimedia.org/r/682568

gerritbot added a project: Patch-For-Review.Apr 26 2021, 10:12 AM

Change 682568 merged by jenkins-bot: