Page MenuHomePhabricator
Create Task
Maniphest T280817

Move WikibaseRepo ItemMergeInteractor to service container
Closed, ResolvedPublic
Actions

Description

This depends on T280814: Move WikibaseRepo ItemRedirectCreationInteractor to service container, and the outcome will depend on how we deal with the context argument in that task.

Details

SubjectRepoBranchLines +/-
Make WikibaseRepo::getItemMergeInteractor() staticmediawiki/extensions/Wikibasemaster+1 -1
Move WikibaseRepo ItemMergeInteractor to service containermediawiki/extensions/Wikibasemaster+113 -54
Ensure context paramter is required in mergeItemsmediawiki/extensions/Wikibasemaster+39 -66
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 21 2021, 4:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 4:03 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 21 2021, 4:03 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Waiting for other services on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 21 2021, 10:50 PM
ItamarWMDE claimed this task.Apr 22 2021, 4:52 PM
ItamarWMDE moved this task from Waiting for other services to Doing on the Wikibase Service Migration board.
ItamarWMDE mentioned this in T280959: WikibaseRepo: Introduce TokenCheckInteractor service.Apr 23 2021, 7:55 AM
gerritbot added a comment.Apr 23 2021, 8:00 AM

Change 682089 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Ensure context paramter is required in mergItems

https://gerrit.wikimedia.org/r/682089

gerritbot added a project: Patch-For-Review.Apr 23 2021, 8:00 AM
gerritbot added a comment.Apr 23 2021, 1:59 PM

Change 682133 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo ItemMergeInteractor to service container

https://gerrit.wikimedia.org/r/682133

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 23 2021, 2:03 PM
ItamarWMDE mentioned this in T280984: WikibaseRepo: Remove getDefaultInstance().Apr 23 2021, 3:35 PM
gerritbot added a comment.Apr 23 2021, 7:51 PM

Change 682089 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Ensure context paramter is required in mergeItems

https://gerrit.wikimedia.org/r/682089

gerritbot added a comment.Apr 23 2021, 7:51 PM

Change 682133 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo ItemMergeInteractor to service container

https://gerrit.wikimedia.org/r/682133

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2021, 8:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 23 2021, 11:00 PM
Rosalie_WMDE closed this task as Resolved.Apr 26 2021, 6:24 AM
Rosalie_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
gerritbot added a comment.Apr 26 2021, 10:12 AM

Change 682568 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Make WikibaseRepo::getItemMergeInteractor() static

https://gerrit.wikimedia.org/r/682568

gerritbot added a project: Patch-For-Review.Apr 26 2021, 10:12 AM
gerritbot added a comment.Apr 27 2021, 10:43 AM

Change 682568 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make WikibaseRepo::getItemMergeInteractor() static

https://gerrit.wikimedia.org/r/682568

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.4; 2021-05-04); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 27 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 27 2021, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits