Page MenuHomePhabricator

Preferences link in mobile notifications is broken on phones
Open, MediumPublic2 Estimated Story PointsBUG REPORT

Description

Preferences link in mobile notifications is broken on phones with screen width of less than 720px (works on tablets).

https://en.m.wikipedia.org/wiki/Special:Notifications (to find this page, click All notifications).

Broken:
image.png (1×1 px, 210 KB)
Looks good at wider screen size:
image.png (1×1 px, 291 KB)

The problem is caused by this CSS rule: (but I don't know what else it does, so I'm not submitting a patch)

@media (max-width: 720px)
.mw-echo-ui-overlay .oo-ui-clippableElement-clippable {
    width: 100% !important;
}
Broken:
image.png (2×3 px, 1 MB)
Fixed:
image.png (2×3 px, 1 MB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh triaged this task as Medium priority.May 4 2021, 1:54 PM
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh moved this task from Inbox to Triaged on the Growth-Team board.

Change 814912 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/Echo@master] Echo mobile: remove CSS media query class

https://gerrit.wikimedia.org/r/814912

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0457351a6e/w

@ovasileva Hello! I think we need a review from your team for this patch. Thanks in advance!

Echo works differently on Minerva depending on whether you are on mobile or desktop domain (some users set their desktop skin to Minerva)

In the latter I'm seeing a bug with the suggested change on https://en.wikipedia.org/wiki/Main_Page?useskin=minerva
Note the gap to the right of the overlay

Screen Shot 2022-07-20 at 1.49.28 PM.png (1×1 px, 216 KB)

Screen Shot 2022-07-20 at 1.49.18 PM.png (1×1 px, 252 KB)

Suggestion: could we update the CSS rule to only apply to this overlay?

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0457351a6e/w/

>>! In T280839#8087998, @Scardenasmolinar wrote:

@ovasileva Hello! I think we need a review from your team for this patch. Thanks in advance!

@Scardenasmolinar it was pointed out to be by @Jdlrobson that echo-related bits of this extension are owned by growth, so we should ping them about review. Sorry for the inaccurate guidance on this one!

Sorry about that. Based on feedback from Jon, I have fixed the error without breaking the Echo notification overlay. A review is appreciated :)

Bugfix-preferences.gif (510×442 px, 268 KB)

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/60040461f3/w

Change 814912 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Echo mobile: add CSS media query class

https://gerrit.wikimedia.org/r/814912

Checked in beta cluster (and wmf.22): the link to Preferences (in the absence of "Mark all as read in selected wiki [...]") is displayed correctly. When "Mark as read..." link is present - the Preference link will be left-aligned and not visible; "Mark as read..." link will be partially visible (the issue was also reported in T287057: [wmf.14] mobile - mw-echo-ui-specialHelpMenuWidget-menu hides "Preference" label ):

Screen Shot 2022-07-29 at 12.00.44 PM.png (1×728 px, 132 KB)
width: 393
Screen Shot 2022-07-29 at 1.55.02 PM.png (1×804 px, 121 KB)

Change 820549 had a related patch set uploaded (by Eigyan; author: Eigyan):

[mediawiki/extensions/Echo@master] Echo mobile: add CSS media query class - bug fix

https://gerrit.wikimedia.org/r/820549