Page MenuHomePhabricator

Provide a destructive variant of the close icon
Closed, ResolvedPublic

Description

Most icons apparently do not have a destructive variant: https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons&theme=wikimediaui&direction=ltr&platform=desktop (select "Destructive" button on top)

Arguably most icons don't really make sense in a destructive context, but there are plenty which do but do have a destructive variant, for example alert/error/notice, clear, close, logOut.

Event Timeline

Change 681941 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[oojs/ui@master] Add destructive variant for close icon

https://gerrit.wikimedia.org/r/681941

I mean… yes? I'm not sure what the task here is for. This is intentional. Every variant of every icon bloats the code for every other user. We've been very careful in trying to limit the number of bytes shipped, as that's been the main complaint from teams.

The particular request seems fine, though it's a change to our design standards as the X is meant to be close, not a "not done" indicator like you're using it here. If the design team have discussed this and are OK with this change, that's fine by me. :-)

I'd suggest re-purposing this task to "Provide a destructive variant of the close icon", or Invaliding the task?

All hundred or so icons have a progressive variant, even though presumably not every single one of them is used somewhere, so it doesn't seem like OOUI is trying to avoid unneeded icons that hard. In any case, compression should pretty much wipe out the size increase since the new variant is almost identical to the original. If limiting destructive icons to those with a specific use case is nevertheless important, let's decline this, the close icon can be discussed in Gerrit.

Change 681941 merged by jenkins-bot:

[oojs/ui@master] Add destructive variant for close icon

https://gerrit.wikimedia.org/r/681941

Jdforrester-WMF renamed this task from Many OOUI icons do not have a destructive variant to Provide a destructive variant of the close icon.May 25 2021, 12:49 AM
Jdforrester-WMF moved this task from Backlog to OOUI-0.42.0 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOUI-0.42.0); removed OOUI.

Change 713803 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.42.0

https://gerrit.wikimedia.org/r/713803

Change 713803 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.42.0

https://gerrit.wikimedia.org/r/713803

Volker_E assigned this task to Tgr.
Volker_E triaged this task as Lowest priority.