Page MenuHomePhabricator

Enforce check for uncompressed SVG files in Popups CI
Closed, ResolvedPublic

Description

This task is for adding a check for unoptimized SVGs in the Popups's repo, similar to how svg_check.sh is used in the MobileFrontend and MinerveNeue repos. This check will ensure CI and precommit hooks will fail when unoptimized SVGs are found.

See this patch for more context on this change

Changes

  • dev-scripts/svg_check.sh is added to the Popups repo
  • svg_check is run during the npm test script

Event Timeline

Change 682017 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/extensions/Popups@master] Enforce check for uncompressed SVG files in Popups CI

https://gerrit.wikimedia.org/r/682017

Jdlrobson subscribed.

There is a volunteer patch awaiting code review.

Change 682017 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] build: Enforce check for uncompressed SVG files in CI

https://gerrit.wikimedia.org/r/682017

Change 683550 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Suppress subsequent errors in svg_check.sh

https://gerrit.wikimedia.org/r/683550

Change 683550 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Suppress subsequent errors in svg_check.sh

https://gerrit.wikimedia.org/r/683550

bwang removed bwang as the assignee of this task.