Page MenuHomePhabricator

Dismiss Chrome's `Save password?` popup
Closed, ResolvedPublic

Description

save-password.png (821ร—998 px, 202 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptApr 23 2021, 10:44 AM

Change 689505 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):

[mediawiki/core@master] Selenium : Dismissed Chrome's `Save password?` popup

https://gerrit.wikimedia.org/r/689505

Hey @zeljkofilipin ! Can you review the patch above , once you feel free as i have some doubts related to it.

@zeljkofilipin: Ya I was thinking that instead of applying changes right now, I should made changes in basic wdio.conf.js to wdio-mediawiki after T281484 is merged, So the popup will be disabled in all repos, without duplication of code. What are your review on this?

@Sahilgrewalhere I don't see that 689505 is rebased on top of 683898. Do you need help?

So sorry @zeljkofilipin for not replying on time.. I was out of action for some personal issue.. i apologize

@Sahilgrewalhere no problem at all, I was just checking if you need help. Take your time.

Change 689505 merged by jenkins-bot:

[mediawiki/core@master] selenium: Dismiss Chrome's `Save password?` popup

https://gerrit.wikimedia.org/r/689505