Page MenuHomePhabricator

Not all legacy tools are in the legacy_redirector.lua configuration
Closed, ResolvedPublic

Description

Tool with downservice getting redirected to www.toolforge -> Wikitech portal... instead of serving the HTTP 50x error.

Actual:

Expected:

Event Timeline

This is caused by the legacy url scheme (tools.wmflabs.org/<tool>). In T247236: Toolforge: introduce a system to preserve old tools.wmflabs.org URLs we built a system that redirects from tools.wmflabs.org/<tool> to <tool>.toolforge.org, but we did not want new tools to use the legacy naming. As a result we have coded a list of "allowed" tool names for redirecting into https://github.com/wikimedia/puppet/blob/production/modules/profile/files/toolforge/legacy_redirector.lua. The simple tool is old enough to have this redirecting allowed, but was apparently not running a webservice when the last capture of tool names to allow was done.

bd808 renamed this task from Tool with downservice getting redirected to www.toolforge -> Wikitech portal to Not all legacy tools are in the legacy_redirector.lua configuration.Fri, Apr 23, 9:27 PM
bd808 updated the task description. (Show Details)

Marking as "needs discussion" for the new cloud-services-team meeting. The question I have is if we should fix this by:

  1. Update the legacy_redirector.lua data to include all tools created prior to 2020-07-07
  2. Add something to https://wikitech.wikimedia.org/wiki/Portal:Toolforge explaining about the legacy domain handling
  3. Make a different landing page on Wikitech to send things not in legacy_redirector.lua to
  4. Some combination of these things

I think adding entries there on a case-by-case basis seems fine, but per our IRC chat, I agree this particular tool doesn't need it right now, as it has been down for over two years. (If and when it comes back, a redirect could be made if it is needed for something, but very likely it'd instead propagate from its new URL only at that time.)

Adding it anyway would also be harmless, though, I think, so I'm neutral either way.

Thanks for noticing @Krinkle. I own the tool and it is intended to be running, but I was not monitoring it recently and did not notice that it has already been down for so long. If a redirect can be created, that would be great!

Change 682325 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/puppet@production] toolforge: Add all tools created before 2020-07-07 to legacy_redirector

https://gerrit.wikimedia.org/r/682325

Change 682325 merged by Arturo Borrero Gonzalez:

[operations/puppet@production] toolforge: Add all tools created before 2020-07-07 to legacy_redirector

https://gerrit.wikimedia.org/r/682325

Mentioned in SAL (#wikimedia-cloud) [2021-04-26T12:17:20Z] <arturo> allowing more tools into the legacy redirector (T281003)

Having older tools in the list definitely wont hurt, so I merged the patch by @bd808

bd808 claimed this task.

The originally reported failing URL here now works, which I think means that they will all work. Thanks for the merge and deploy @aborrero