Page MenuHomePhabricator
Create Task
Maniphest T281008

PHPCS should send a warning when tests don't call parent::setUp(), parent::tearDown(), etc.
Open, Needs TriagePublic
Actions

Description

Specifically, if a test overrides setUpBeforeClass, setUp, tearDown, or tearDownAfterClass the override should call the original parent method (for setup, the call normally goes at the start, and for tear down, it normally goes at the end, but having it anywhere is better than not having at all)

Details

SubjectRepoBranchLines +/-
Add new sniff MediaWiki.PHPUnit.ParentCallmediawiki/tools/codesniffermaster+205 -19
Add new sniff MediaWiki.PHPUnit.ParentCallmediawiki/coremaster+0 -0
Customize query in gerrit

Event Timeline

DannyS712 created this task.Apr 23 2021, 10:59 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 23 2021, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Apr 23 2021, 10:59 PM

Change 682164 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Add new sniff MediaWiki.PHPUnit.ParentCall

https://gerrit.wikimedia.org/r/682164

gerritbot added a project: Patch-For-Review.Apr 23 2021, 10:59 PM

Change 682164 abandoned by DannyS712:

[mediawiki/core@master] Add new sniff MediaWiki.PHPUnit.ParentCall

Reason:

oops, wrong repo

https://gerrit.wikimedia.org/r/682164

gerritbot added a comment.Apr 23 2021, 11:00 PM

Change 682165 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/tools/codesniffer@master] Add new sniff MediaWiki.PHPUnit.ParentCall

https://gerrit.wikimedia.org/r/682165

DannyS712 moved this task from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.Apr 23 2021, 11:01 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Umherirrender added a parent task: T329395: Define the scope codesniffer should act on PHPUnit test code to enforce a code style.Feb 10 2023, 9:30 PM
Umherirrender removed a parent task: T329395: Define the scope codesniffer should act on PHPUnit test code to enforce a code style.Feb 18 2023, 10:47 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Sep 17 2023, 3:59 PM
DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:42 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL