Page MenuHomePhabricator

When using {{Information}} with an empty description a TypeError is thrown (must be an instance of Wikibase\DataModel\Entity\ItemId)
Closed, ResolvedPublic

Description

Reproduction steps:

  1. Go to a file on betacommons (https://commons.wikimedia.beta.wmflabs.org/wiki/File:76f2dbef4cc9_29.jpg is as good as any)
  2. Go into source edit
  3. Enter "{{Information}}"
  4. Preview
[YIQefFrBz5aes84o3pFVYQAAABc] /w/index.php?title=File:76f2dbef4cc9_29.jpg&action=submit TypeError: Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings::trackUsageForSitelink() must be an instance of Wikibase\DataModel\Entity\ItemId, instance of Wikibase\MediaInfo\DataModel\MediaInfoId given, called in /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php on line 168

Backtrace:

from /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php(305)
#0 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php(168): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings->trackUsageForSitelink(string, Wikibase\MediaInfo\DataModel\MediaInfoId)
#1 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(565): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings->getEntityId(string, string)
#2 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->getEntityId(string)
#3 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#4 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#5 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(296): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#6 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(68): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#7 /srv/mediawiki/php-master/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#8 /srv/mediawiki/php-master/includes/parser/Parser.php(3356): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#9 /srv/mediawiki/php-master/includes/parser/Parser.php(3041): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#10 /srv/mediawiki/php-master/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#11 /srv/mediawiki/php-master/includes/parser/PPTemplateFrame_Hash.php(97): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#12 /srv/mediawiki/php-master/includes/parser/Parser.php(3227): PPTemplateFrame_Hash->cachedExpand(string, PPNode_Hash_Tree)
#13 /srv/mediawiki/php-master/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#14 /srv/mediawiki/php-master/includes/parser/Parser.php(2879): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#15 /srv/mediawiki/php-master/includes/parser/Parser.php(1549): Parser->replaceVariables(string)
#16 /srv/mediawiki/php-master/includes/parser/Parser.php(639): Parser->internalParse(string)
#17 /srv/mediawiki/php-master/includes/content/WikitextContent.php(375): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#18 /srv/mediawiki/php-master/includes/content/AbstractContent.php(591): WikitextContent->fillParserOutput(Title, NULL, ParserOptions, boolean, ParserOutput)
#19 /srv/mediawiki/php-master/includes/EditPage.php(4245): AbstractContent->getParserOutput(Title, NULL, ParserOptions)
#20 /srv/mediawiki/php-master/includes/EditPage.php(4150): EditPage->doPreviewParse(WikitextContent)
#21 /srv/mediawiki/php-master/includes/EditPage.php(2927): EditPage->getPreviewText()
#22 /srv/mediawiki/php-master/includes/EditPage.php(733): EditPage->showEditForm()
#23 /srv/mediawiki/php-master/includes/actions/EditAction.php(71): EditPage->edit()
#24 /srv/mediawiki/php-master/includes/actions/SubmitAction.php(38): EditAction->show()
#25 /srv/mediawiki/php-master/includes/MediaWiki.php(535): SubmitAction->show()
#26 /srv/mediawiki/php-master/includes/MediaWiki.php(319): MediaWiki->performAction(ImagePage, Title)
#27 /srv/mediawiki/php-master/includes/MediaWiki.php(916): MediaWiki->performRequest()
#28 /srv/mediawiki/php-master/includes/MediaWiki.php(550): MediaWiki->main()
#29 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#30 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#31 /srv/mediawiki/w/index.php(3): require(string)
#32 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore claimed this task.
Addshore subscribed.

We don't appear to be able to reproduce this right now
We have recently touched some of this code so its highly likely this is now just fixed!