Page MenuHomePhabricator

Confusing reply tool dirty diff (caused by history merge)
Closed, ResolvedPublic


This reply tool diff looks really bad:

image.png (2×1 px, 399 KB)

But this is misleading. The actual changes made in that edit can be seen in this diff:

image.png (1×1 px, 167 KB)

The diff, and the page history, are all messed up because the history of two pages was merged into one:

See the logs here:

The original diff is actually a comparison of two completely different pages.

Event Timeline

(I filed this so that a link to this explanation shows up on, there's no other action needed.)

ppelberg claimed this task.

This diff found in dtcheck is caused by the same scenario:

If it keeps occurring, maybe at some point I'll try to find a way to stop detecting these. Not now though.

Actually this seems easy to fix, the recent changes data includes the ID of the previous revision at the time the edit was made, and we should be using that ID instead of the ID of the previous revision right now.

Fixed by this change:

After re-running everything, no longer includes the false positive:

image.png (2×3 px, 408 KB)
image.png (2×3 px, 164 KB)

The stats for 2021-07-23 are also corrected, and no other days changed unexpectedly.

Older occurrences in dtcheck will not be updated, because the recent changes data is only available for the last 30 days.