Page MenuHomePhabricator

Rename AbuseFilter indexes for consistency
Open, Stalled, MediumPublic

Description

See parent task for details, several indexes should be renamed for consistency with non-MySQL schemas and to make it easier to find schema drifts.

What: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/593906/20/db_patches/mysql/patch-rename-indexes.sql

Where: All wikis

When: Whenever DBAs can, this is not blocking anything

Is backwards compatible: Yes, nothing is using these indeces explicitly

Has been tested already: Yes, locally.

Schema change progress:

  • s1
    • eqiad
    • codfw
  • s2
    • eqiad
    • codfw
  • s3
    • eqiad
    • codfw
  • s4
    • eqiad
    • codfw
  • s5
    • eqiad
    • codfw
  • s6
    • eqiad
    • codfw
  • s7
    • eqiad
    • codfw
  • s8
    • eqiad
    • codfw
  • s10
  • labtestwiki

Event Timeline

Marostegui triaged this task as Medium priority.Apr 26 2021, 5:49 AM
Marostegui moved this task from Triage to Ready on the DBA board.

@Daimona did you do a search on code to make sure there's no FORCE INDEX for any of those?

@Daimona did you do a search on code to make sure there's no FORCE INDEX for any of those?

Yes, there are no FORCE/USE INDEX in the codebase (just an unrelated one for the revision table).

Excellent, thank you!

Kormat moved this task from Ready to In progress on the DBA board.
Kormat added a subscriber: Kormat.

Schema change made on s6 eqiad replica (db1096:3316). Will leave to soak over the weekend.

Mentioned in SAL (#wikimedia-operations) [2021-07-20T09:39:06Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 14 hosts with reason: Deploying schema change to s6 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T09:39:14Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 14 hosts with reason: Deploying schema change to s6 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:14:21Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 13 hosts with reason: Deploying schema change to s5 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:14:27Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 13 hosts with reason: Deploying schema change to s5 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:25:22Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 15 hosts with reason: Deploying schema change to s2 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:25:29Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 15 hosts with reason: Deploying schema change to s2 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:50:02Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 15 hosts with reason: Deploying schema change to s7 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:50:09Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 15 hosts with reason: Deploying schema change to s7 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:12:13Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 4:00:00 on 18 hosts with reason: Deploying schema change to s4 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:12:20Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 4:00:00 on 18 hosts with reason: Deploying schema change to s4 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:30:13Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 2:00:00 on 18 hosts with reason: Deploying schema change to s8 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:30:20Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 2:00:00 on 18 hosts with reason: Deploying schema change to s8 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T15:06:14Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 4:00:00 on 12 hosts with reason: Deploying schema change to s3 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-20T15:06:21Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 4:00:00 on 12 hosts with reason: Deploying schema change to s3 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-21T08:31:30Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 2:00:00 on 18 hosts with reason: Deploying schema change to s1 T281058

Mentioned in SAL (#wikimedia-operations) [2021-07-21T08:31:37Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 2:00:00 on 18 hosts with reason: Deploying schema change to s1 T281058

Kormat changed the task status from Open to Stalled.Wed, Jul 21, 8:53 AM
Kormat updated the task description. (Show Details)
Kormat moved this task from In progress to Blocked on the DBA board.

Stalling this until we switch back to eqiad.