Page MenuHomePhabricator
Create Task
Maniphest T281058

Rename AbuseFilter indexes for consistency
Closed, ResolvedPublic
Actions

Description

See parent task for details, several indexes should be renamed for consistency with non-MySQL schemas and to make it easier to find schema drifts.

What: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/593906/20/db_patches/mysql/patch-rename-indexes.sql

Where: All wikis

When: Whenever DBAs can, this is not blocking anything

Is backwards compatible: Yes, nothing is using these indeces explicitly

Has been tested already: Yes, locally.

Schema change progress:

  • s1
    • eqiad
    • codfw
  • s2
    • eqiad
    • codfw
  • s3
    • eqiad
    • codfw
  • s4
    • eqiad
    • codfw
  • s5
    • eqiad
    • codfw
  • s6
    • eqiad
    • codfw
  • s7
    • eqiad
    • codfw
  • s8
    • eqiad
    • codfw
  • s10
  • labtestwiki

Related Objects
Search...

Event Timeline

Daimona created this task.Apr 25 2021, 9:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2021, 9:42 AM
Daimona added a subtask: T251613: Change the abusefilter database index definition.Apr 25 2021, 9:43 AM
Daimona removed a subtask: T251613: Change the abusefilter database index definition.
Daimona added a parent task: T251613: Change the abusefilter database index definition.
Daimona updated the task description. (Show Details)
• Marostegui triaged this task as Medium priority.Apr 26 2021, 5:49 AM
• Marostegui moved this task from Triage to Ready on the DBA board.
• Marostegui subscribed.May 11 2021, 11:18 AM

@Daimona did you do a search on code to make sure there's no FORCE INDEX for any of those?

LSobanski moved this task from Ready to Blocked on the DBA board.May 11 2021, 11:29 AM
Daimona added a comment.May 11 2021, 11:45 AM
In T281058#7077561, @Marostegui wrote:

@Daimona did you do a search on code to make sure there's no FORCE INDEX for any of those?

Yes, there are no FORCE/USE INDEX in the codebase (just an unrelated one for the revision table).

• Marostegui moved this task from Blocked to Ready on the DBA board.May 11 2021, 11:46 AM

Excellent, thank you!

Kormat claimed this task.Jul 16 2021, 1:43 PM
Kormat moved this task from Ready to In progress on the DBA board.
Kormat subscribed.

Schema change made on s6 eqiad replica (db1096:3316). Will leave to soak over the weekend.

Kormat moved this task from Backlog to In progress on the Schema-change-in-production board.Jul 16 2021, 1:43 PM
Stashbot added a comment.Jul 20 2021, 9:39 AM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T09:39:06Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 14 hosts with reason: Deploying schema change to s6 T281058

Stashbot added a comment.Jul 20 2021, 9:39 AM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T09:39:14Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 14 hosts with reason: Deploying schema change to s6 T281058

Kormat updated the task description. (Show Details)Jul 20 2021, 1:13 PM
Stashbot added a comment.Jul 20 2021, 1:14 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:14:21Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 13 hosts with reason: Deploying schema change to s5 T281058

Stashbot added a comment.Jul 20 2021, 1:14 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:14:27Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 13 hosts with reason: Deploying schema change to s5 T281058

Stashbot added a comment.Jul 20 2021, 1:25 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:25:22Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 15 hosts with reason: Deploying schema change to s2 T281058

Stashbot added a comment.Jul 20 2021, 1:25 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:25:29Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 15 hosts with reason: Deploying schema change to s2 T281058

Kormat updated the task description. (Show Details)Jul 20 2021, 1:43 PM
Kormat updated the task description. (Show Details)Jul 20 2021, 1:49 PM
Stashbot added a comment.Jul 20 2021, 1:50 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:50:02Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 15 hosts with reason: Deploying schema change to s7 T281058

Stashbot added a comment.Jul 20 2021, 1:50 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T13:50:09Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 15 hosts with reason: Deploying schema change to s7 T281058

Kormat updated the task description. (Show Details)Jul 20 2021, 2:03 PM
Stashbot added a comment.Jul 20 2021, 2:12 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:12:13Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 4:00:00 on 18 hosts with reason: Deploying schema change to s4 T281058

Stashbot added a comment.Jul 20 2021, 2:12 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:12:20Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 4:00:00 on 18 hosts with reason: Deploying schema change to s4 T281058

Stashbot added a comment.Jul 20 2021, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:30:13Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 2:00:00 on 18 hosts with reason: Deploying schema change to s8 T281058

Stashbot added a comment.Jul 20 2021, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T14:30:20Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 2:00:00 on 18 hosts with reason: Deploying schema change to s8 T281058

Kormat updated the task description. (Show Details)Jul 20 2021, 3:05 PM
Stashbot added a comment.Jul 20 2021, 3:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T15:06:14Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 4:00:00 on 12 hosts with reason: Deploying schema change to s3 T281058

Stashbot added a comment.Jul 20 2021, 3:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-20T15:06:21Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 4:00:00 on 12 hosts with reason: Deploying schema change to s3 T281058

Stashbot added a comment.Jul 21 2021, 8:31 AM

Mentioned in SAL (#wikimedia-operations) [2021-07-21T08:31:30Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 2:00:00 on 18 hosts with reason: Deploying schema change to s1 T281058

Stashbot added a comment.Jul 21 2021, 8:31 AM

Mentioned in SAL (#wikimedia-operations) [2021-07-21T08:31:37Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 2:00:00 on 18 hosts with reason: Deploying schema change to s1 T281058

Kormat changed the task status from Open to Stalled.Jul 21 2021, 8:53 AM
Kormat updated the task description. (Show Details)
Kormat moved this task from In progress to Blocked on the DBA board.

Stalling this until we switch back to eqiad.

DannyS712 mentioned this in T291719: Remove abuse_filter_log.afl_filter column and adjust schema consequently from Wikimedia production.Sep 25 2021, 6:41 AM
Daimona added a comment.Sep 25 2021, 10:26 AM

I guess this is now unblocked, right?

• Marostegui changed the task status from Stalled to Open.Sep 27 2021, 4:39 AM
• Marostegui moved this task from Blocked to Ready on the DBA board.

Yes, this is ready to go. @Kormat is out on holidays at the moment.

Kormat changed the task status from Open to In Progress.Oct 18 2021, 1:46 PM
Kormat updated the task description. (Show Details)
Kormat updated the task description. (Show Details)Oct 18 2021, 1:59 PM
Kormat updated the task description. (Show Details)Oct 18 2021, 2:13 PM
Stashbot added a comment.Oct 18 2021, 2:59 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T14:59:37Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on 11 hosts with reason: Schema change s7 T281058

Stashbot added a comment.Oct 18 2021, 2:59 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T14:59:45Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on 11 hosts with reason: Schema change s7 T281058

Kormat updated the task description. (Show Details)Oct 18 2021, 3:15 PM
Stashbot added a comment.Oct 18 2021, 3:16 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T15:16:06Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 3:00:00 on 13 hosts with reason: Schema change s4 T281058

Stashbot added a comment.Oct 18 2021, 3:16 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T15:16:16Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 3:00:00 on 13 hosts with reason: Schema change s4 T281058

Kormat updated the task description. (Show Details)Oct 18 2021, 3:22 PM
Stashbot added a comment.Oct 18 2021, 3:23 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T15:23:20Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 18:00:00 on 7 hosts with reason: Schema change s3 T281058

Stashbot added a comment.Oct 18 2021, 3:23 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T15:23:26Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 18:00:00 on 7 hosts with reason: Schema change s3 T281058

Kormat updated the task description. (Show Details)Oct 19 2021, 8:14 AM
Stashbot added a comment.Oct 19 2021, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T08:33:43Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 2:00:00 on 13 hosts with reason: Schema change s8 T281058

Stashbot added a comment.Oct 19 2021, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T08:33:53Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 2:00:00 on 13 hosts with reason: Schema change s8 T281058

Kormat updated the task description. (Show Details)Oct 19 2021, 8:49 AM
Kormat changed the task status from In Progress to Stalled.Oct 19 2021, 9:04 AM

All that's left is s1 in codfw, which is currently blocked on work that's happening for T290865: Upgrade s1 to Buster + MariaDB 10.4.

Stashbot added a comment.Oct 19 2021, 9:18 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T09:18:30Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 2:00:00 on 14 hosts with reason: Schema change s1 T281058

Stashbot added a comment.Oct 19 2021, 9:18 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T09:18:41Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 2:00:00 on 14 hosts with reason: Schema change s1 T281058

Kormat closed this task as Resolved.Oct 19 2021, 9:31 AM
Kormat updated the task description. (Show Details)

Got unblocked, deployed to s1/codfw, and we're now done!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL