Page MenuHomePhabricator
Create Task
Maniphest T281113

Stop using DBAccessBase in EntityChangeLookup
Closed, ResolvedPublic
Actions

Description

Instead, it’s probably better to directly inject an ILoadBalancer into the constructor.

Details

SubjectRepoBranchLines +/-
Inject ILoadBalancer into EntityChangeLookupmediawiki/extensions/Wikibasemaster+27 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 26 2021, 10:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 10:49 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 26 2021, 10:50 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 26 2021, 3:27 PM
Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.Apr 26 2021, 10:27 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 28 2021, 10:09 AM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 28 2021, 10:48 AM

Change 683255 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Inject ILoadBalancer into EntityChangeLookup

https://gerrit.wikimedia.org/r/683255

gerritbot added a project: Patch-For-Review.Apr 28 2021, 10:48 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 28 2021, 11:58 AM
gerritbot added a comment.Apr 28 2021, 1:24 PM

Change 683255 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inject ILoadBalancer into EntityChangeLookup

https://gerrit.wikimedia.org/r/683255

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 28 2021, 1:52 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 28 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2021, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL