Risky Patch! 🚂🔥

• Changes:
  • https://gerrit.wikimedia.org/r/c/mediawiki/core/+/681644/ (removing support for Revision objects in Linker methods)
  • https://gerrit.wikimedia.org/r/c/mediawiki/core/+/681730/ (remove Revision objects from WikiPage)
  • https://gerrit.wikimedia.org/r/c/mediawiki/core/+/683957/ (remove deprecated talk page message handling in User class, including UserRetrieveNewTalks hook)
  • https://gerrit.wikimedia.org/r/c/mediawiki/core/+/683964/ (remove remaining non-test uses of Revision objects)
  • TDB: extension patches, including parsoid
• What it does/What it's risky:
  • There's nothing particularly risky about this one, but it's big and touching a lot of code. Specifically, we are continuing the removal of the Revision class and associated code. This week we removed all non-test uses of Revision objects from core, and (hopefully) also the support for Revision objects in extensions. All of this code was already hard deprecated and should not have been executed in production. We are going to hold off on actually deleting the Revision class for at least a week, to make sure it goes into the next train in case there were any issues.
• Test Plan:
  • This should have all been dead code emitting deprecation warnings, so there isn't really anything to test, just watching the logs
• Places to Watch for Breakage
  • Logstash MediaWiki Errors Dashboard: https://logstash.wikimedia.org/app/kibana#/dashboard/mediawiki-errors
  • Grafana Production Logging Dashboard: https://grafana.wikimedia.org/d/000000102/production-logging
• Revert Plan: rollback
• Wikis Affected: all
• IRC Contact: @DannyS712 (or @Pchelolo if I'm not around)
• UBN Task Projects/tags: User-DannyS712 (Platform Engineering if I'm not around)

wmf.5 is at group0.

I cherry-picked https://gerrit.wikimedia.org/r/c/mediawiki/core/+/689532 to wmf.5 if someone could merge + deploy it.

@dancy following on from @Legoktm comment above, it would be preferred by the team that introduced the bug to backport https://gerrit.wikimedia.org/r/c/mediawiki/core/+/689889 instead of the one @Legoktm has pointed to.

I would do it during the backport window myself in a few hours.. but the window is full. Will make sure one of myself, @cjming, @bwang is around to test during the train window at 12-2pm PST.

In T281146#7082400, @Jdlrobson wrote:

@dancy following on from @Legoktm comment above, it would be preferred by the team that introduced the bug to backport https://gerrit.wikimedia.org/r/c/mediawiki/core/+/689889 instead of the one @Legoktm has pointed to.

OK.

I would do it during the backport window myself in a few hours.. but the window is full. Will make sure one of myself, @cjming, @bwang is around to test during the train window at 12-2pm PST.

Are you referring to the morning backport window? Looking at https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210512T1800 I only see one patch listed there (689545) so you should be able to get in there.

Right you are! I was looking at the European one (face palm!) On it!

End of day status: Blocked at group0, looks like there's a potential patch in the works for T282735. Hopefully that can be deployed in US morning at latest.

End of day status: Blocked at group1 due to some new error messages in logs.

• T282833 MapSourcesPage.php: PHP Notice: Undefined offset: xx
• T282834 LogEventsList.php: PHP Notice: Undefined variable: pageName

T282825 is also generating noise but it is deprecation warning so I made it a blocker for next week's train. There is already a patch ready for review

OK, train should now be unblocked again, with thanks to @Pchelolo and @tstarling.

wmf.5 is now deployed to all wikis.