Page MenuHomePhabricator
Create Task
Maniphest T281165

1.38.0-wmf.1 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.38.0-wmf.1
Release Date
Sep 20 2021, 12:00 AM

2021 week 38 1.38-wmf.1 Changes wmf/1.38.0-wmf.1

This MediaWiki Train Deployment is scheduled for the week of Monday, September 20th:

Monday September 20thTuesday, September 21stWednesday, September 22ndThursday, September 23rdFriday
Backports only.Branch wmf.1 and deploy to Group 0 Wikis.Deploy wmf.1 to Group 1 Wikis.Deploy wmf.1 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.1 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.37.0-wmf.23
Next: 1.38.0-wmf.2

Related Objects
Search...

Event Timeline

thcipriani created this task.Apr 26 2021, 3:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 3:15 PM
thcipriani renamed this task from 1.37.0-wmf.24 deployment blockers to 1.38.0-wmf.1 deployment blockers.Aug 24 2021, 6:47 PM
thcipriani assigned this task to • dduvall.
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Doing).
thcipriani changed Release Version from 1.37.0-wmf.24 to 1.38.0-wmf.1.
Zabe added subtasks: T290871: Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete in /var/www/html/core/includes/actions/DeleteAction.php at line 230], T290914: GlobalUsage is using hard deprecated Title::getBacklinkCache, T290909: CirrusSearch is using hard deprecated Title::getBacklinkCache.Sep 14 2021, 6:04 AM
Zabe closed subtask T290909: CirrusSearch is using hard deprecated Title::getBacklinkCache as Resolved.Sep 14 2021, 5:38 PM
Zabe closed subtask T290914: GlobalUsage is using hard deprecated Title::getBacklinkCache as Resolved.Sep 14 2021, 5:51 PM
Zabe closed subtask T290871: Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete in /var/www/html/core/includes/actions/DeleteAction.php at line 230] as Resolved.Sep 14 2021, 5:54 PM
thcipriani added a subtask: T291108: PHP Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete].Sep 15 2021, 6:24 PM
hashar reopened subtask T290909: CirrusSearch is using hard deprecated Title::getBacklinkCache as Open.Sep 15 2021, 7:32 PM
Zabe closed subtask T290909: CirrusSearch is using hard deprecated Title::getBacklinkCache as Resolved.Sep 15 2021, 7:52 PM
DannyS712 subscribed.Sep 17 2021, 5:21 PM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/718414 (T267861)
  • Summary: (Why is it risky?)
    • The global variable $wgUser is no longer a User object by default, but rather a StubGlobalUser until it is interacted with. Calling any methods on it will trigger a deprecation warning, and passing it to a method that has a User (or UserIdentity or Authority) typehint will break (as seen at T291217)
  • Test plan:
    • In theory all existing uses of $wgUser in core and deployed extensions should be writes or gated behind deprecated code, so nothing should be happening - just ensure that there are no errors
  • Places to monitor:
  • Revert plan: rollback train.
  • Affected wikis: All
  • IRC Contact: Pchelolo, DannyS712
  • UBN Task Projects/tags: Platform Engineering, User-DannyS712
Legoktm subscribed.Sep 20 2021, 6:46 PM
Risky Patches! 🚂🔥
matmarex subscribed.Sep 20 2021, 9:51 PM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/713681 "Always apply DiscussionTools page transformations" (T273072, T280599)
  • Summary:
    • Additional markup will be added to the parser output of discussion pages, and cached in the parser cache. It could cause discussion and non-discussion pages to look wrong (unlikely), and parser cache to go crazy (very unlikely).
  • Test plan:
    • There should be no user-visible changes. You can look at the HTML markup of discussion headings and comments to see if it's there (might need to use action=purge first), see examples in T273072 under Technical description.
  • Places to monitor:
  • Revert plan: Revert patch. Note that this is all about cache stuff, so you may continue seeing issues after reverting for a bit.
  • Affected wikis: All
  • IRC contact: MatmaRex
  • UBN Task Projects/tags: Editing-team
taavi subscribed.Sep 21 2021, 4:26 AM

The branch cut seems to have happened for the wrong branch (1.37.0-wmf.24): https://gerrit.wikimedia.org/r/c/mediawiki/core/+/722480/

DannyS712 added a comment.Sep 21 2021, 4:59 AM
In T281165#7367712, @Majavah wrote:

The branch cut seems to have happened for the wrong branch (1.37.0-wmf.24): https://gerrit.wikimedia.org/r/c/mediawiki/core/+/722480/

It looks like the branch is assumed to just be the prior /wmf/ branch with the version incremented by one, i.e. no handling for new releases
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/release/+/61c19981ef1928de8c425890a4176b01f25f2167/bin/train-branch-cut-job.sh#6

Stashbot added a comment.Sep 21 2021, 3:48 PM

Mentioned in SAL (#wikimedia-releng) [2021-09-21T15:48:41Z] <James_F> Updated the releases-jenkins automatic branch cut job to make 1.38.0 branches (missed ahead of T281165)

Stashbot added a comment.Sep 21 2021, 3:49 PM

Mentioned in SAL (#wikimedia-releng) [2021-09-21T15:49:34Z] <James_F> Re-running the branch cut job for T281165

Zabe subscribed.Sep 21 2021, 4:22 PM
Stashbot added a comment.Sep 21 2021, 4:26 PM

Mentioned in SAL (#wikimedia-releng) [2021-09-21T16:26:51Z] <dduvall> deleted wmf/1.37.0-wmf.24 and wmf/1.38.0-wmf.1 branches due to a branch cut job gone awry. re-running job to cut wmf/1.38.0-wmf.1 (T281165)

matmarex mentioned this in T291459: Reply link brackets appear in the preview while replying using reply tool in source mode.Sep 21 2021, 5:08 PM
matmarex mentioned this in T291460: History view of talk pages displays incorrectly (entries split over multiple lines).
Stashbot added a comment.Sep 21 2021, 5:49 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-21T17:49:21Z] <dduvall> 1.38.0-wmf.1 deployed to testwikis (T281165)

• dduvall added a comment.Sep 21 2021, 5:50 PM

The release-notes diff between the errant 1.37.0-wmf.24 branch cut and the later 1.38.0-wmf.1 branch cut can be seen here.

https://www.mediawiki.org/w/index.php?diff=4819281&oldid=4818542

hashar subscribed.Sep 21 2021, 7:04 PM
• dduvall mentioned this in T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute].Sep 21 2021, 7:14 PM
• dduvall added a parent task: T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute].
• dduvall removed a parent task: T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute].Sep 21 2021, 7:20 PM
• dduvall added a subtask: T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute].
DannyS712 changed the status of subtask T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute] from Open to In Progress.Sep 21 2021, 8:42 PM
Stashbot added a comment.Sep 22 2021, 7:29 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-22T19:29:57Z] <dduvall> 1.38.0-wmf.1 promoted to group1. no new errors or rising error rates (T281165)

kostajh subscribed.Sep 22 2021, 7:40 PM
In T281165#7367204, @matmarex wrote:
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/713681 "Always apply DiscussionTools page transformations" (T273072, T280599)
  • Summary:
    • Additional markup will be added to the parser output of discussion pages, and cached in the parser cache. It could cause discussion and non-discussion pages to look wrong (unlikely), and parser cache to go crazy (very unlikely).
  • Test plan:
    • There should be no user-visible changes. You can look at the HTML markup of discussion headings and comments to see if it's there (might need to use action=purge first), see examples in T273072 under Technical description.
  • Places to monitor:
  • Revert plan: Revert patch. Note that this is all about cache stuff, so you may continue seeing issues after reverting for a bit.
  • Affected wikis: All
  • IRC contact: MatmaRex
  • UBN Task Projects/tags: Editing-team

image.png (550×1 px, 371 KB)

@matmarex is this related? Shows up when doing a search on Commons.

matmarex added a comment.EditedSep 22 2021, 7:46 PM

Definitely related, I'll look into it. Can you file a task? I filed T291590.

(that's https://commons.wikimedia.org/wiki/Special:MediaSearch)

matmarex mentioned this in T291590: DiscussionTools markup appears in dropdowns on Special:MediaSearch.Sep 22 2021, 8:12 PM
Stashbot added a comment.Sep 23 2021, 8:04 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-23T20:04:17Z] <dduvall> 1.38.0-wmf.1 promoted to all wikis. no new errors or rising rates (T281165)

• dduvall closed this task as Resolved.Sep 23 2021, 10:44 PM
• dduvall removed a subtask: T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute].
• dduvall added a subtask: T291515: PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute].Sep 23 2021, 11:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL