Page MenuHomePhabricator

1.38.0-wmf.1 deployment blockers
Open, MediumPublic5 Estimated Story PointsRelease

Details

Backup Train Conductor
hashar
Release Version
1.38.0-wmf.1
Release Date
Mon, Sep 20, 12:00 AM

2021 week 38 1.38-wmf.1 Changes wmf/1.38.0-wmf.1

This MediaWiki Train Deployment is scheduled for the week of Monday, September 20th:

Monday September 20thTuesday, September 21stWednesday, September 22ndThursday, September 23rdFriday
Backports only.Branch wmf.1 and deploy to Group 0 Wikis.Deploy wmf.1 to Group 1 Wikis.Deploy wmf.1 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.1 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.37.0-wmf.23
Next: 1.38.0-wmf.2

Related Objects

Event Timeline

thcipriani renamed this task from 1.37.0-wmf.24 deployment blockers to 1.38.0-wmf.1 deployment blockers.Tue, Aug 24, 6:47 PM
thcipriani assigned this task to dduvall.
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.
thcipriani changed Release Version from 1.37.0-wmf.24 to 1.38.0-wmf.1.
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/718414 (T267861)
  • Summary: (Why is it risky?)
    • The global variable $wgUser is no longer a User object by default, but rather a StubGlobalUser until it is interacted with. Calling any methods on it will trigger a deprecation warning, and passing it to a method that has a User (or UserIdentity or Authority) typehint will break (as seen at T291217)
  • Test plan:
    • In theory all existing uses of $wgUser in core and deployed extensions should be writes or gated behind deprecated code, so nothing should be happening - just ensure that there are no errors
  • Places to monitor:
  • Revert plan: rollback train.
  • Affected wikis: All
  • IRC Contact: Pchelolo, DannyS712
  • UBN Task Projects/tags: Platform Engineering, User-DannyS712
Risky Patches! 🚂🔥
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/713681 "Always apply DiscussionTools page transformations" (T273072, T280599)
  • Summary:
    • Additional markup will be added to the parser output of discussion pages, and cached in the parser cache. It could cause discussion and non-discussion pages to look wrong (unlikely), and parser cache to go crazy (very unlikely).
  • Test plan:
    • There should be no user-visible changes. You can look at the HTML markup of discussion headings and comments to see if it's there (might need to use action=purge first), see examples in T273072 under Technical description.
  • Places to monitor:
  • Revert plan: Revert patch. Note that this is all about cache stuff, so you may continue seeing issues after reverting for a bit.
  • Affected wikis: All
  • IRC contact: MatmaRex
  • UBN Task Projects/tags: Editing-team

The branch cut seems to have happened for the wrong branch (1.37.0-wmf.24): https://gerrit.wikimedia.org/r/c/mediawiki/core/+/722480/

The branch cut seems to have happened for the wrong branch (1.37.0-wmf.24): https://gerrit.wikimedia.org/r/c/mediawiki/core/+/722480/

It looks like the branch is assumed to just be the prior /wmf/ branch with the version incremented by one, i.e. no handling for new releases
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/release/+/61c19981ef1928de8c425890a4176b01f25f2167/bin/train-branch-cut-job.sh#6

Mentioned in SAL (#wikimedia-releng) [2021-09-21T15:48:41Z] <James_F> Updated the releases-jenkins automatic branch cut job to make 1.38.0 branches (missed ahead of T281165)

Mentioned in SAL (#wikimedia-releng) [2021-09-21T15:49:34Z] <James_F> Re-running the branch cut job for T281165

Mentioned in SAL (#wikimedia-releng) [2021-09-21T16:26:51Z] <dduvall> deleted wmf/1.37.0-wmf.24 and wmf/1.38.0-wmf.1 branches due to a branch cut job gone awry. re-running job to cut wmf/1.38.0-wmf.1 (T281165)

Mentioned in SAL (#wikimedia-operations) [2021-09-21T17:49:21Z] <dduvall> 1.38.0-wmf.1 deployed to testwikis (T281165)

The release-notes diff between the errant 1.37.0-wmf.24 branch cut and the later 1.38.0-wmf.1 branch cut can be seen here.

https://www.mediawiki.org/w/index.php?diff=4819281&oldid=4818542

Mentioned in SAL (#wikimedia-operations) [2021-09-22T19:29:57Z] <dduvall> 1.38.0-wmf.1 promoted to group1. no new errors or rising error rates (T281165)

Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/713681 "Always apply DiscussionTools page transformations" (T273072, T280599)
  • Summary:
    • Additional markup will be added to the parser output of discussion pages, and cached in the parser cache. It could cause discussion and non-discussion pages to look wrong (unlikely), and parser cache to go crazy (very unlikely).
  • Test plan:
    • There should be no user-visible changes. You can look at the HTML markup of discussion headings and comments to see if it's there (might need to use action=purge first), see examples in T273072 under Technical description.
  • Places to monitor:
  • Revert plan: Revert patch. Note that this is all about cache stuff, so you may continue seeing issues after reverting for a bit.
  • Affected wikis: All
  • IRC contact: MatmaRex
  • UBN Task Projects/tags: Editing-team

image.png (550×1 px, 371 KB)

@matmarex is this related? Shows up when doing a search on Commons.

Definitely related, I'll look into it. Can you file a task? I filed T291590.

(that's https://commons.wikimedia.org/wiki/Special:MediaSearch)