Use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider in extensions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Vlad.shapik
	Apr 26 2021, 4:36 PM

Description

Usages of these methods were removed from the core.

Steps:

Use https://codesearch.wmcloud.org/search/ tool to find all the usages of AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer methods in extensions. Make a list, WMF deployed extensions separately, not WMF deployed extensions separately (you can select Wikimedia deployed) in the tool
All usages of deprecated methods must be replaced with AbstractAuthenticationProvider::init. If it's overridden AbstractAuthenticationProvider::setConfig, so replace it with AbstractAuthenticationProvider::postInitSetup.
Patches for all extensions that are not deployed should be created, but there's no requirement for them to get merged.
When the patches of the deployed extensions will be merged, hard deprecate the setters.

Here is the parent patch - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/680327

WMF deployed

extensions / OATHAuth
extensions / AntiSpoof
extensions / ConfirmEdit
extensions / TitleBlacklist

Not WMF deployed

extensions / EmailAuth
extensions / PasswordlessLogin

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hard deprecate the setters of AbstractAuthenticationProvider class	mediawiki/core	master	+31 -21

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Vlad.shapik	T281174 Use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider in extensions
Resolved	Vlad.shapik	T281991 extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Resolved	Vlad.shapik	T281992 extensions/AntiSpoof - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Resolved	Vlad.shapik	T281993 extensions/ConfirmEdit - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Resolved	Vlad.shapik	T281994 extensions/TitleBlacklist - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Resolved	Vlad.shapik	T281995 extensions/EmailAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Resolved	Vlad.shapik	T281996 extensions/PasswordlessLogin - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider

Event Timeline

Vlad.shapik created this task.Apr 26 2021, 4:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 4:36 PM

Vlad.shapik triaged this task as Medium priority.Apr 26 2021, 8:17 PM

Vlad.shapik removed Vlad.shapik as the assignee of this task.Apr 30 2021, 1:26 PM

Vlad.shapik added projects: MediaWiki-extensions-CentralAuth, MediaWiki-extensions-OATHAuth, AntiSpoof, ConfirmEdit (CAPTCHA extension), TitleBlacklist, MediaWiki-extensions-EmailAuth, PasswordlessLogin.May 3 2021, 4:00 PM

Vlad.shapik updated the task description. (Show Details)

Vlad.shapik claimed this task.May 3 2021, 4:03 PM

Vlad.shapik moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.

Vlad.shapik edited projects, added Technical-Debt (Deprecation process); removed PasswordlessLogin, MediaWiki-extensions-EmailAuth, TitleBlacklist, ConfirmEdit (CAPTCHA extension), AntiSpoof, MediaWiki-extensions-OATHAuth, MediaWiki-extensions-CentralAuth.May 3 2021, 4:56 PM

@Vlad.shapik: Was the removal of project tags intentional (e.g. to create dedicated subtasks for each extension)?

Re-added codebase tags, so people interested in tickets about a codebase can find these tickets about that codebase.

Since necessary subtasks for each codebase have already been created, the appropriate tags were removed from the ticket.

Vlad.shapik updated the task description. (Show Details)May 5 2021, 3:36 PM

Vlad.shapik removed a subtask: T281990: extensions/CentralAuth - use SessionProvider ::init, ::postInitSetup instead of the setters of SessionProvider .May 5 2021, 3:58 PM

Vlad.shapik renamed this task from Hard deprecate AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer to Use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider.May 6 2021, 2:54 PM

Vlad.shapik renamed this task from Use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider to Use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider in extensions.

Vlad.shapik updated the task description. (Show Details)May 6 2021, 5:45 PM

Vlad.shapik mentioned this in T275030: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName.May 7 2021, 11:53 AM

Vlad.shapik moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.May 7 2021, 3:52 PM

Vlad.shapik updated the task description. (Show Details)May 7 2021, 4:30 PM

Vlad.shapik closed subtask T281995: extensions/EmailAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider as Resolved.May 10 2021, 11:34 AM

Vlad.shapik updated the task description. (Show Details)May 10 2021, 2:35 PM

Vlad.shapik closed subtask T281991: extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider as Resolved.May 13 2021, 2:36 PM

Vlad.shapik updated the task description. (Show Details)

Vlad.shapik closed this task as Resolved.May 25 2021, 4:54 PM

Vlad.shapik reopened this task as Open.

Vlad.shapik closed subtask T281996: extensions/PasswordlessLogin - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider as Resolved.May 26 2021, 8:36 AM

Vlad.shapik closed subtask T281993: extensions/ConfirmEdit - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider as Resolved.