Page MenuHomePhabricator
Create Task
Maniphest T281180

DiscussionTools: Precondition failed: This Title instance does not represent a proper page, but merely a link target
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
  • mwversion: master
normalized_message
Precondition failed: This Title instance does not represent a proper page, but merely a link target
exception.trace
Original exception: [YIb0Vy1sB3RCSPte8h5OtAAAAAA] /wiki/Special:EditGrowthConfig Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent a proper page, but merely a link target.
Backtrace:
from /srv/mediawiki/php-master/vendor/wikimedia/assert/src/Assert.php(49)
#0 /srv/mediawiki/php-master/includes/Title.php(4645): Wikimedia\Assert\Assert::precondition(boolean, string)
#1 /srv/mediawiki/php-master/includes/Title.php(4626): Title->assertProperPage()
#2 /srv/mediawiki/php-master/includes/PageProps.php(242): Title->getId()
#3 /srv/mediawiki/php-master/includes/PageProps.php(105): PageProps->getGoodIDs(Title)
#4 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/Hooks/HookUtils.php(182): PageProps->getProperties(Title, array)
#5 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/Hooks/PageHooks.php(48): MediaWiki\Extension\DiscussionTools\Hooks\HookUtils::isAvailableForTitle(Title)
#6 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\DiscussionTools\Hooks\PageHooks->onBeforePageDisplay(OutputPage, SkinVector)
#7 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(1000): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#8 /srv/mediawiki/php-master/includes/OutputPage.php(2642): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinVector)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(930): OutputPage->output(boolean)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(943): MediaWiki::{closure}()
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(550): MediaWiki->main()
#12 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}
Impact

Special pages in (beta) wikis down, classifying as train blocker.

Notes

Sounds to be caused by DiscussionTools work.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+8 -17Revert "PageProps: use PageIdentity instead of Title"
mediawiki/extensions/DiscussionToolsmaster+4 -1Abort DiscussionTools checks early when viewing a special page
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm triaged this task as Unbreak Now! priority.Apr 26 2021, 5:15 PM
Urbanecm created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 5:15 PM
Natuur12 added a subscriber: Natuur12.Apr 26 2021, 5:18 PM
Bas_dehaan added a subscriber: Bas_dehaan.Apr 26 2021, 5:18 PM
matmarex added a subscriber: matmarex.EditedApr 26 2021, 5:24 PM

Caused by a change in MediaWiki core: rMW07d885248bc5: PageProps: use PageIdentity instead of Title.

Urbanecm updated the task description. (Show Details)Apr 26 2021, 5:35 PM
gerritbot added a comment.Apr 26 2021, 5:40 PM

Change 682699 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Abort DiscussionTools checks early when viewing a special page

https://gerrit.wikimedia.org/r/682699

gerritbot added a project: Patch-For-Review.Apr 26 2021, 5:40 PM
matmarex claimed this task.Apr 26 2021, 5:40 PM
matmarex edited projects, added Editing-team (FY2021-22 Kanban Board); removed Editing-team.
matmarex moved this task from Incoming to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
matmarex added a subtask: T281184: PHP Fatal Error: Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker.Apr 26 2021, 5:55 PM
Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.Apr 26 2021, 6:23 PM
matmarex mentioned this in T281011: Deploy the source mode with tools as an opt-in setting on the beta cluster.Apr 26 2021, 7:17 PM
gerritbot added a comment.Apr 26 2021, 7:19 PM

Change 682699 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Abort DiscussionTools checks early when viewing a special page

https://gerrit.wikimedia.org/r/682699

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 26 2021, 8:00 PM
taavi closed subtask T281184: PHP Fatal Error: Access level to CentralAuthPrimaryAuthenticationProvider::$userNameUtils must be protected (as in class MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider) or weaker as Resolved.Apr 26 2021, 8:06 PM
matmarex added a comment.Apr 26 2021, 8:09 PM

This should be fixed now, but I still see the exception on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences. How long does it take until the change gets deployed?

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 8:10 PM
Urbanecm added a comment.Apr 26 2021, 8:29 PM
In T281180#7035792, @matmarex wrote:

This should be fixed now, but I still see the exception on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences. How long does it take until the change gets deployed?

Generally up to 30 minutes. You can see the deployment job progress at https://integration.wikimedia.org/ci/job/beta-scap-sync-world/ and https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/.

The page works for me now.

gerritbot added a comment.Apr 26 2021, 8:30 PM

Change 682714 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Revert "PageProps: use PageIdentity instead of Title"

https://gerrit.wikimedia.org/r/682714

gerritbot added a project: Patch-For-Review.Apr 26 2021, 8:30 PM
gerritbot added a comment.Apr 26 2021, 9:00 PM

Change 682714 merged by jenkins-bot:

[mediawiki/core@master] Revert "PageProps: use PageIdentity instead of Title"

https://gerrit.wikimedia.org/r/682714

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 9:10 PM
matmarex closed this task as Resolved.Apr 26 2021, 9:15 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL