Page MenuHomePhabricator

DiscussionTools: Precondition failed: This Title instance does not represent a proper page, but merely a link target
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
  • mwversion: master
normalized_message
Precondition failed: This Title instance does not represent a proper page, but merely a link target
exception.trace
Original exception: [YIb0Vy1sB3RCSPte8h5OtAAAAAA] /wiki/Special:EditGrowthConfig Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent a proper page, but merely a link target.
Backtrace:
from /srv/mediawiki/php-master/vendor/wikimedia/assert/src/Assert.php(49)
#0 /srv/mediawiki/php-master/includes/Title.php(4645): Wikimedia\Assert\Assert::precondition(boolean, string)
#1 /srv/mediawiki/php-master/includes/Title.php(4626): Title->assertProperPage()
#2 /srv/mediawiki/php-master/includes/PageProps.php(242): Title->getId()
#3 /srv/mediawiki/php-master/includes/PageProps.php(105): PageProps->getGoodIDs(Title)
#4 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/Hooks/HookUtils.php(182): PageProps->getProperties(Title, array)
#5 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/Hooks/PageHooks.php(48): MediaWiki\Extension\DiscussionTools\Hooks\HookUtils::isAvailableForTitle(Title)
#6 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\DiscussionTools\Hooks\PageHooks->onBeforePageDisplay(OutputPage, SkinVector)
#7 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(1000): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#8 /srv/mediawiki/php-master/includes/OutputPage.php(2642): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinVector)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(930): OutputPage->output(boolean)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(943): MediaWiki::{closure}()
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(550): MediaWiki->main()
#12 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}
Impact

Special pages in (beta) wikis down, classifying as train blocker.

Notes

Sounds to be caused by DiscussionTools work.

Event Timeline

Urbanecm triaged this task as Unbreak Now! priority.Mon, Apr 26, 5:15 PM
Urbanecm created this task.

Change 682699 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Abort DiscussionTools checks early when viewing a special page

https://gerrit.wikimedia.org/r/682699

Change 682699 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Abort DiscussionTools checks early when viewing a special page

https://gerrit.wikimedia.org/r/682699

This should be fixed now, but I still see the exception on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences. How long does it take until the change gets deployed?

This should be fixed now, but I still see the exception on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences. How long does it take until the change gets deployed?

Generally up to 30 minutes. You can see the deployment job progress at https://integration.wikimedia.org/ci/job/beta-scap-sync-world/ and https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/.

The page works for me now.

Change 682714 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Revert "PageProps: use PageIdentity instead of Title"

https://gerrit.wikimedia.org/r/682714

Change 682714 merged by jenkins-bot:

[mediawiki/core@master] Revert "PageProps: use PageIdentity instead of Title"

https://gerrit.wikimedia.org/r/682714