Page MenuHomePhabricator

Hard deprecate watchlist methods in User
Closed, ResolvedPublic

Description

Remove usages and hard deprecate the following User methods:

  • isWatched(): use WatchlistManager::isWatched() or WatchlistManager:isWatchedIgnoringRights() instead
  • isTempWatched(): use WatchlistManager::isTempWatched() or WatchlistManager:isTempWatchedIgnoringRights() instead
  • addWatch(): use WatchlistManager::addWatch() or WatchlistManager::addWatchIgnoringRights() instead
  • removeWatch(): use WatchlistManager::removeWatch() or WatchlistManager::removeWatchIgnoringRights() instead

Usages in core have already been removed except for in User tests.

Wikimedia production extensions/skins:

  • Echo
  • LiquidThreads
  • FlaggedRevs
  • VisualEditor
  • Wikibase
  • WikibaseMediaInfo
  • MinervaNeue (skin)
  • Nostalgia (skin)

Other extensions/skins:

  • BlueSpiceSocialWatch
  • CreateAPage
  • MediaWikiAuth (master compatibility policy)
  • PageForms (master compatibility policy)
  • PushToWatch
  • TranslateSvg
  • Video
  • WhoIsWatching
  • Apex (skin)
  • Metrolook (skin)
  • Nimbus (skin)
  • Strapping (skin)
  • WebPlatform (skin)
  • Moderation (github: https://github.com/edwardspec/mediawiki-moderation/pull/63)
  • OAuthAuthentication (incompatible with MW 1.35+)

Core:

  • Hide deprecations in watchlist-related User tests
  • Hard deprecate User::isWatched(), User::isTempWatched(), User::addWatch(), and User::removeWatch()

Details

ProjectBranchLines +/-Subject
mediawiki/skins/webplatformmaster+5 -2
mediawiki/extensions/MediaWikiAuthmaster+7 -1
mediawiki/skins/mediawiki-strappingmaster+5 -2
mediawiki/skins/Metrolookmaster+5 -2
mediawiki/skins/Nimbusmaster+4 -3
mediawiki/extensions/CreateAPagemaster+3 -2
mediawiki/coremaster+9 -0
mediawiki/extensions/Wikibasemaster+37 -20
mediawiki/extensions/Videomaster+4 -3
mediawiki/extensions/VisualEditormaster+8 -5
mediawiki/extensions/BlueSpiceSocialWatchmaster+1 -1
mediawiki/extensions/TranslateSvgmaster+5 -4
mediawiki/extensions/WhoIsWatchingmaster+13 -2
mediawiki/extensions/PageFormsmaster+48 -11
mediawiki/extensions/Echomaster+4 -2
mediawiki/skins/MinervaNeuemaster+1 -1
mediawiki/extensions/FlaggedRevsmaster+1 -1
mediawiki/extensions/LiquidThreadsmaster+1 -1
mediawiki/skins/Nostalgiamaster+1 -1
mediawiki/extensions/PushToWatchmaster+2 -1
mediawiki/extensions/WikibaseMediaInfomaster+1 -1
mediawiki/skins/apexmaster+3 -0
mediawiki/extensions/WikibaseMediaInfomaster+4 -2
mediawiki/skins/MinervaNeuemaster+17 -4
mediawiki/extensions/FlaggedRevsmaster+22 -8
mediawiki/skins/Nostalgiamaster+1 -1
mediawiki/extensions/LiquidThreadsmaster+7 -3
mediawiki/extensions/BlueSpiceSocialWatchmaster+12 -12
mediawiki/skins/apexmaster+4 -1
mediawiki/extensions/PushToWatchmaster+6 -2
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 683009 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/LiquidThreads@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683009

Change 683015 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/Wikibase@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683015

Change 683021 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/Echo@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683021

Change 683017 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/BlueSpiceSocialWatch@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683017

Change 683057 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/FlaggedRevs@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683057

Change 683058 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/VisualEditor@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683058

Change 683059 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/WikibaseMediaInfo@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683059

Change 683060 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/CreateAPage@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683060

Change 683061 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/MediaWikiAuth@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683061

Change 683062 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/PageForms@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683062

Change 683063 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/PushToWatch@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683063

Change 683065 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/TranslateSvg@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683065

Change 683066 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/Video@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683066

Change 683069 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/WhoIsWatching@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683069

Change 683073 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/MinervaNeue@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683073

Change 683076 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/Nostalgia@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683076

Change 683077 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/apex@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683077

Change 683078 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/Metrolook@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683078

Change 683080 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/Nimbus@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683080

Change 683082 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/mediawiki-strapping@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683082

Change 683084 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/skins/webplatform@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683084

Change 683063 merged by jenkins-bot:

[mediawiki/extensions/PushToWatch@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683063

Change 683077 merged by jenkins-bot:

[mediawiki/skins/apex@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683077

Change 683017 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSocialWatch@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683017

Change 683009 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683009

Change 683057 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683057

Change 683076 merged by jenkins-bot:

[mediawiki/skins/Nostalgia@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683076

Change 683059 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683059

Change 683073 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683073

Change 683393 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikibaseMediaInfo@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683393

Change 683394 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/MinervaNeue@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683394

Change 683396 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/FlaggedRevs@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683396

Change 683397 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/Nostalgia@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683397

Change 683398 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/LiquidThreads@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683398

Change 683399 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/BlueSpiceSocialWatch@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683399

Change 683400 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/apex@master] Set required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683400

Change 683401 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PushToWatch@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683401

Change 683393 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683393

Change 683400 merged by jenkins-bot:

[mediawiki/skins/apex@master] Set required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683400

Change 683401 merged by jenkins-bot:

[mediawiki/extensions/PushToWatch@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683401

Change 683394 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683394

Change 683397 merged by jenkins-bot:

[mediawiki/skins/Nostalgia@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683397

Change 683396 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683396

Change 683398 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683398

Change 683442 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/core@master] Hard deprecate watchlist methods in User

https://gerrit.wikimedia.org/r/683442

Change 683021 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683021

Change 683062 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683062

Change 683069 merged by jenkins-bot:

[mediawiki/extensions/WhoIsWatching@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683069

Change 683065 merged by jenkins-bot:

[mediawiki/extensions/TranslateSvg@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683065

Change 683399 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSocialWatch@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683399

Change 683058 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683058

Change 683015 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683015

Change 683442 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate watchlist methods in User

https://gerrit.wikimedia.org/r/683442

CCicalese_WMF updated the task description. (Show Details)

All core changes and Wikimedia production extension/skin changes have been merged. Patches have been submitted against non-Wikimedia extensions/skins, but it is up to their maintainers to complete that process.

Change 683078 merged by jenkins-bot:

[mediawiki/skins/Metrolook@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683078

Change 683082 merged by jenkins-bot:

[mediawiki/skins/mediawiki-strapping@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683082

Change 683061 abandoned by Jforrester:

[mediawiki/extensions/MediaWikiAuth@master] Replace usage of deprecated User watchlist methods

Reason:

Per T282955, this repo has been moved to GitHub.

https://gerrit.wikimedia.org/r/683061

Change 683084 merged by jenkins-bot:

[mediawiki/skins/webplatform@master] Replace usage of deprecated User watchlist methods

https://gerrit.wikimedia.org/r/683084