Page MenuHomePhabricator

InvalidArgumentException: GrowthExperiments\Config\WikiPageConfigWriter::getCurrentWikiConfig failed to load config
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: GrowthExperiments\Config\WikiPageConfigWriter::getCurrentWikiConfig failed to load config
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/includes/Config/WikiPageConfigWriter.php(99)
#0 /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/includes/Config/WikiPageConfigWriter.php(111): GrowthExperiments\Config\WikiPageConfigWriter->getCurrentWikiConfig()
#1 /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/includes/Config/WikiPageConfigWriter.php(147): GrowthExperiments\Config\WikiPageConfigWriter->loadConfig()
#2 /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/includes/Config/WikiPageConfigWriter.php(159): GrowthExperiments\Config\WikiPageConfigWriter->setVariable(string, array)
#3 /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(510): GrowthExperiments\Config\WikiPageConfigWriter->setVariables(array)
#4 /srv/mediawiki/php-1.37.0-wmf.3/includes/htmlform/HTMLForm.php(715): GrowthExperiments\Specials\SpecialEditGrowthConfig->onSubmit(array, OOUIHTMLForm)
#5 /srv/mediawiki/php-1.37.0-wmf.3/includes/htmlform/HTMLForm.php(605): HTMLForm->trySubmit()
#6 /srv/mediawiki/php-1.37.0-wmf.3/includes/htmlform/HTMLForm.php(621): HTMLForm->tryAuthorizedSubmit()
#7 /srv/mediawiki/php-1.37.0-wmf.3/includes/specialpage/FormSpecialPage.php(187): HTMLForm->show()
#8 /srv/mediawiki/php-1.37.0-wmf.3/includes/specialpage/SpecialPage.php(646): FormSpecialPage->execute(NULL)
#9 /srv/mediawiki/php-1.37.0-wmf.3/includes/specialpage/SpecialPageFactory.php(1397): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(313): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(916): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(550): MediaWiki->main()
#13 /srv/mediawiki/php-1.37.0-wmf.3/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.37.0-wmf.3/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Impact

Low, for now. Only one instance, but on testwiki, which is worrying. If this starts happening more on testwiki, or on group0, I'll make it into a train blocker and raise priority to Unbreak Now.

Notes
MediaWiki:GrowthExperimentsConfig.json as-of error
{
    "GEHelpPanelAskMentor": true,
    "GEHelpPanelExcludedNamespaces": [],
    "GEHelpPanelHelpDeskPostOnTop": false,
    "GEHelpPanelHelpDeskTitle": "Wikipedia:Requests/Help_desk",
    "GEHelpPanelLinks": [
        {
            "title": "EditingHelp",
            "text": "Write a Wikipedia article using the right style",
            "id": "style"
        },
        {
            "title": "Wikipedia:Creation_and_usage_of_media_files",
            "text": "Add an image",
            "id": "image"
        },
        {
            "title": "Wikipedia:Citing_sources",
            "text": "Add a citation",
            "id": "citation"
        },
        {
            "title": "How_to_add_an_external_link",
            "text": "How to add an external link",
            "id": "externallink"
        },
        {
            "title": "Help:Infobox",
            "text": "How to add/edit the infobox",
            "id": "infobox"
        }
    ],
    "GEHelpPanelReadingModeNamespaces": [
        2,
        4,
        12,
        2,
        4,
        12
    ],
    "GEHelpPanelSearchNamespaces": [
        4,
        12,
        4,
        12
    ],
    "GEHelpPanelSuggestedEditsPreferredEditor": "visualeditor",
    "GEHelpPanelViewMoreTitle": "Special:MyLanguage/Help:Contents",
    "GEHomepageManualAssignmentMentorsList": null,
    "GEHomepageMentorsList": "Wikipedia:Requests/Help desk/Mentors",
    "GEHomepageSuggestedEditsIntroLinks": {
        "create": "Help:Creating pages",
        "image": "Help:Images"
    },
    "GEMentorshipEnabled": true
}

Extra context logged to GrowthExperiments: <code>GEHomepageManualAssignmentMentorsList</code> is expected to be <code>string</code>, but is <code>NULL</code>

Looks to be caused by GEHomepageManualAssignmentMentorsList being null in the config file. That is fine, MentorManager can deal with this variable being null.

Event Timeline

kostajh triaged this task as High priority.Tue, Apr 27, 9:27 AM
kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
kostajh added subscribers: Urbanecm_WMF, kostajh.

@Urbanecm_WMF could you have a look at this please?

Change 682913 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigValidation: Mentor lists and help desk can be null

https://gerrit.wikimedia.org/r/682913

Note: I deleted MediaWiki:GrowthExperimentsConfig.json from test.wikipedia, which should suppress this error. Once the patch I have for this task will get backported, I'll undo my deletion and make sure the error doesn't happen anymore.

Change 682913 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigValidation: Mentor lists and help desk can be null

https://gerrit.wikimedia.org/r/682913

Change 682812 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] WikiPageConfigValidation: Mentor lists and help desk can be null

https://gerrit.wikimedia.org/r/682812

Change 682812 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] WikiPageConfigValidation: Mentor lists and help desk can be null

https://gerrit.wikimedia.org/r/682812

Mentioned in SAL (#wikimedia-operations) [2021-04-27T13:08:04Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.3/extensions/GrowthExperiments/includes/Config/WikiPageConfigValidation.php: fe2a0420fd884df7046c0c283bcb2e961e74e8e9: WikiPageConfigValidation: Mentor lists and help desk can be null (T281229) (duration: 01m 06s)