Page MenuHomePhabricator

Separate beta and non-beta user setting for reference previews
Open, Needs TriagePublic3 Estimated Story Points

Description

In T277638: Separate user setting for RefPreviews and Page Previews for default we introduced separate settings for the two popup types Page-Previews and Reference Previews. Before, ReferencePreviews was a BetaFeature the user can opt-in to, to be stored in the database with the key popupsreferencepreviews. The current code reuses the same key when not in beta any more.

While there is code in place that tries to not persist the beta feature flag as long as the user doesn't intentionally interact with it, this doesn't work. The moment a user touches any user preference – no matter which one – and clicks "save", popupsreferencepreviews is stored with the default 0. We want these users to get ReferencePreviews. Since there is no way to distinguish this (large) group of users from the (small) group of users that enabled and later intentionally disabled the beta feature, we need to enable the feature for all of them. This can easily be achieved by using two different keys for the beta and the non-beta preference.

This was announced like this:

Event Timeline

Change 682924 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] [WIP] Separate beta and non-beta user settings

https://gerrit.wikimedia.org/r/682924

thiemowmde set the point value for this task to 3.
thiemowmde moved this task from Backlog to Doing on the Reference Previews board.

Change 682926 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Separate reference preview settings in beta & non-beta

https://gerrit.wikimedia.org/r/682926

Change 682926 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Separate reference preview settings in beta & non-beta

https://gerrit.wikimedia.org/r/682926

Change 682819 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@wmf/1.37.0-wmf.3] Separate reference preview settings in beta & non-beta

https://gerrit.wikimedia.org/r/682819

Change 682819 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@wmf/1.37.0-wmf.3] Separate reference preview settings in beta & non-beta

https://gerrit.wikimedia.org/r/682819

Scheduled for today's 1pm window https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1909993&oldid=1909899

Change 682819 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.37.0-wmf.3] Separate reference preview settings in beta & non-beta

https://gerrit.wikimedia.org/r/682819

Mentioned in SAL (#wikimedia-operations) [2021-04-28T11:20:33Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.3/extensions/Popups/: 8d0ae5e8fedefa911fc216bfc810d7a6169ea7e5: Separate reference preview settings in beta & non-beta (T281235) (duration: 01m 08s)