Page MenuHomePhabricator

Improve isCaptionExpandable for desktop
Open, Needs TriagePublic

Description

Objective

The expand cue should not be shown if the caption fits in a larger desktop/table screen because expanding the caption is redundant then. See the video below for an example:

We have a isCaptionExpandable method for this purpose but we optimized it for mobile. What we're doing in isCaptionExpandable is looking at the window.innerWidth and the caption string length itself to tell if it's expandable or not, we have to think about a solution that addresses all window sizes.

Follow up from T269854.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
eamedina renamed this task from Reverse caption closing animation on desktop to Improve isCaptionExpandable for desktop .Apr 27 2021, 2:56 PM
eamedina updated the task description. (Show Details)
eamedina updated the task description. (Show Details)