Page MenuHomePhabricator
Create Task
Maniphest T281238

GlobalUsage does selects on the master database
Closed, ResolvedPublic
Actions

Description

GlobalUsage class is created only with master database, see https://gerrit.wikimedia.org/g/mediawiki/extensions/GlobalUsage/+/fd85afae25cab78bc40991fab79a61b5b42c1ed4/includes/Hooks.php#214. That means selects at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalUsage/+/fd85afae25cab78bc40991fab79a61b5b42c1ed4/includes/GlobalUsage.php#75 happen on the master database for no good reason.

This should be remedied ASAP. Likely contributed to todays Wikimedia Commons RO incident.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Avoid reading primary unless absolutely necessaryLadsgroupmediawiki/extensions/GlobalUsagewmf/1.37.0-wmf.1+29 -17
Avoid reading primary unless absolutely necessaryLadsgroupmediawiki/extensions/GlobalUsagewmf/1.37.0-wmf.3+30 -18
Avoid reading primary unless absolutely necessaryLadsgroupmediawiki/extensions/GlobalUsagemaster+30 -18
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Apr 27 2021, 11:15 AM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptApr 27 2021, 11:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm triaged this task as Unbreak Now! priority.Apr 27 2021, 11:15 AM
LSobanski subscribed.Apr 27 2021, 11:15 AM
Marostegui subscribed.Apr 27 2021, 11:16 AM
gerritbot added a comment.Apr 27 2021, 11:30 AM

Change 682927 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/GlobalUsage@master] Avoid reading primary unless absolutely necessary

https://gerrit.wikimedia.org/r/682927

gerritbot added a project: Patch-For-Review.Apr 27 2021, 11:30 AM
gerritbot added a comment.Apr 27 2021, 11:51 AM

Change 682813 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/GlobalUsage@wmf/1.37.0-wmf.3] Avoid reading primary unless absolutely necessary

https://gerrit.wikimedia.org/r/682813

gerritbot added a comment.Apr 27 2021, 11:51 AM

Change 682814 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/GlobalUsage@wmf/1.37.0-wmf.1] Avoid reading primary unless absolutely necessary

https://gerrit.wikimedia.org/r/682814

gerritbot added a comment.Apr 27 2021, 11:55 AM

Change 682927 merged by jenkins-bot:

[mediawiki/extensions/GlobalUsage@master] Avoid reading primary unless absolutely necessary

https://gerrit.wikimedia.org/r/682927

taavi subscribed.Apr 27 2021, 11:57 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 27 2021, 12:00 PM
gerritbot added a comment.Apr 27 2021, 12:01 PM

Change 682813 merged by jenkins-bot:

[mediawiki/extensions/GlobalUsage@wmf/1.37.0-wmf.3] Avoid reading primary unless absolutely necessary

https://gerrit.wikimedia.org/r/682813

gerritbot added a comment.Apr 27 2021, 12:06 PM

Change 682814 merged by jenkins-bot:

[mediawiki/extensions/GlobalUsage@wmf/1.37.0-wmf.1] Avoid reading primary unless absolutely necessary

https://gerrit.wikimedia.org/r/682814

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2021, 12:10 PM
Stashbot added a comment.Apr 27 2021, 12:12 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-27T12:12:38Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.3/extensions/GlobalUsage: Backport: [[gerrit:682813|Avoid reading primary unless absolutely necessary (T281238)]] (duration: 01m 09s)

Stashbot added a comment.Apr 27 2021, 12:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-27T12:20:12Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/GlobalUsage: Backport: [[gerrit:682814|Avoid reading primary unless absolutely necessary (T281238)]] (duration: 01m 09s)

jbond mentioned this in T281242: ReEnable GlobalUsage.Apr 27 2021, 12:24 PM
ReleaseTaggerBot edited projects, added: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13); removed: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 27 2021, 1:00 PM
Jdforrester-WMF subscribed.Apr 27 2021, 3:04 PM

Resolved? Or at least, not UBN?

Ladsgroup closed this task as Resolved.Apr 27 2021, 3:05 PM

I think we can safely close it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits