Page MenuHomePhabricator

flaggedrevs.css loaded after site and user CSS
Closed, ResolvedPublic

Description

Since a few days (possibly caused by the fix of bug 25289), flaggedrevs.css is being loaded after the site and user CSS.

This has broken 1 site-wide customization on dewiki (cf. http://de.wikipedia.org/w/index.php?title=MediaWiki:Monobook.css&diff=81917389&oldid=81917139) and an unknown number of user customizations.


Version: unspecified
Severity: major

Details

Reference
bz26128

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz26128.
  • This bug has been marked as a duplicate of bug 26131 ***

(In reply to comment #2)

> *** This bug has been marked as a duplicate of bug 26131 ***

This isn't really a duplicate of whatever that bug is (Is it about current ext code or one the uses proper RL module registration). This is about code that should work properly on /deployment.

(In reply to comment #3)

(In reply to comment #2)

  • This bug has been marked as a duplicate of bug 26131 ***

This isn't really a duplicate of whatever that bug is (Is it about current ext
code or one the uses proper RL module registration). This is about code that
should work properly on /deployment.

Well, unless it's just a coincidence, this seems to be a very specific example of the general bug described in bug 26131. The resource loader is getting the order of extension stylesheets wrong so that they are loaded after user stylesheets.

I'm not going to mark it as a dupe a second time, because perhaps you know something I don't, but they seem like the same bug to me.

(In reply to comment #3)

(In reply to comment #2)

  • This bug has been marked as a duplicate of bug 26131 ***

This isn't really a duplicate of whatever that bug is (Is it about current ext
code or one the uses proper RL module registration). This is about code that
should work properly on /deployment.

Aaah, this bug is about *deployment*. Yeah then this can't possibly be a dupe, as RL isn't in deployment.

Assigning to Priyanka to investigate further.

pdhanda wrote:

Fixed in trunk and branches/priyanka-wmf-fixes which contains fixes for the next deployment.