Page MenuHomePhabricator

"Expand all sections" feature on mobile does not appear to be working
Closed, ResolvedPublic

Description

Using the mobile site:

  • As anonymous user
  • Visit any page (e.g. use "Random") on a mobile phone
  • Enable "Expand all sections" in mobile settings in the menu.
  • Visit any page (e.g. use "Random") on a mobile phone
  • Observe sections are still collapsed

QA Results - Beta

ACStatusDetails
1T281296#7050363
2T281296#7050363

QA Results - Prod

ACStatusDetails
1T281296#7071237
2T281296#7071237

Event Timeline

Looks like the settings page is using localStorage, but the toggler is searching in sessionStorage (which should only be used for remembering particular sections). Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/655102

Change 683038 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Use localStorage for expandSections boolean

https://gerrit.wikimedia.org/r/683038

Jdlrobson triaged this task as Low priority.
Jdlrobson updated the task description. (Show Details)

Change 683038 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use localStorage for expandSections boolean

https://gerrit.wikimedia.org/r/683038

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Using the mobile site:

As anonymous user
Visit any page (e.g. use "Random") on a mobile phone
Enable "Expand all sections" in mobile settings in the menu.
Visit any page (e.g. use "Random") on a mobile phone
✅ AC1: Observe sections are expanded

Screen Recording 2021-04-30 at 5.55.14 PM.mov.gif (896×414 px, 3 MB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Using the mobile site:

As anonymous user
Visit any page (e.g. use "Random") on a mobile phone
Enable "Expand all sections" in mobile settings in the menu.
Visit any page (e.g. use "Random") on a mobile phone
✅ AC1: Observe sections are expanded

Screen Recording 2021-05-07 at 8.42.00 PM.mov.gif (674×310 px, 1 MB)

Looks good, resolving

Change 690720 had a related patch set uploaded (by Martineznovo; author: Esanders):

[mediawiki/extensions/MobileFrontend@REL1_36] Use localStorage for expandSections boolean

https://gerrit.wikimedia.org/r/690720

Change 690720 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@REL1_36] Use localStorage for expandSections boolean

https://gerrit.wikimedia.org/r/690720