Page MenuHomePhabricator

Feature request: add owner credit on Share-A-Fact cards
Open, MediumPublic

Assigned To
Authored By
Apr 27 2021, 7:42 PM
Referenced Files
F34622297: Option A_ Margarete Schütte-Lihotzky.png
Aug 27 2021, 7:45 PM
F34622315: Option C_ Biscuit.png
Aug 27 2021, 7:45 PM
F34622295: Option A_ Pythagorean.png
Aug 27 2021, 7:45 PM
F34622309: Option B_ RTL.png
Aug 27 2021, 7:45 PM
F34622302: Option B_ Biscuit.png
Aug 27 2021, 7:45 PM
F34622304: Option B_ Pythagorean.png
Aug 27 2021, 7:45 PM
F34622317: Option C_ Pythagorean.png
Aug 27 2021, 7:45 PM
F34622292: Option A_ Biscuit.png
Aug 27 2021, 7:45 PM


From OTRS:

as a fellow Wikipedian I find it very annoying to use the share-a-fact cards of the Wikipedia app when they depict images protected by CC licenses and only attribute them with standard CC-icons without giving appropriate credit to the owners. Could you please implement a standard text field on the image which gives credit to the respective owner of the image?

Why are we doing this?

We need to support giving credit to respective image owners on Share-a-Fact cards

Design needs
  • Support appropriate text in the designs (eg. "Image by XXX" along with the CC icons
  • Support RTL
  • Consider how to handle long names (eg. truncation?)
  • Consider if we want to show credit for CC licenses that do not require attribution (eg CC0)
Figma file

3 Design solutions

The designs include 3 options A, B & C which are exemplified in the table below. All options include the:

  • Article title
  • Text
  • CC icons
  • Wikipedia logo
    • Should be in the language of the article. You can find some of the logos in the various languages here
    • If no logo in a particular language can be found we can try to use the language closest to the original language eg. if not Czech logo can be found use Slovenian. If this is not possible, one can use the English logo as a fallback.
  • 'made by the Wikipe...'
  • 'image by: XXX'.
    • The line that includes 'image by: XXX' can be max. 30 characters with spaces (including the 'image by'). If the image credit exceeds 30 characters the name should be truncated.

Table: 3 Design options for share-a-fact
Currently, the preferred designs are those under option B, due to a clearer hierarchy between the elements.

Different optionsDetails/differences Dark background Light background Varying backgroundRTL
Option A1. The articles title (16px) & the 'made by....' (10px) is located under the text 2. The logo & 'image by: XXX' (10px) is on the bottom of the image
Option A_ Biscuit.png (291×512 px, 131 KB)
Option A_ Pythagorean.png (291×512 px, 27 KB)
Option A_ Margarete Schütte-Lihotzky.png (291×512 px, 71 KB)
Option A_ RTL.png (291×512 px, 173 KB)
Option B (preferred)1. The articles title (20px) is on top of the page, while the logo & 'made by:..' (10px) is under the text 2. 'image by: XXX' (10px) is on the bottom of the image
Option B_ Biscuit.png (291×512 px, 132 KB)
Option B_ Pythagorean.png (291×512 px, 27 KB)
Option B_ Margarete Schütte-Lihotzky.png (291×512 px, 72 KB)
Option B_ RTL.png (291×512 px, 174 KB)
Option C1. The articles title (16px) is located under the text 2. The logo & 'image by: XXX' (6px) is on the bottom of the image
Option C_ Biscuit.png (291×512 px, 130 KB)
Option C_ Pythagorean.png (291×512 px, 26 KB)
Option C_ Margarete Schütte-Lihotzky.png (291×512 px, 70 KB)
RTL.png (291×512 px, 172 KB)

Event Timeline

LGoto triaged this task as Medium priority.May 3 2021, 6:51 PM
LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.
Dmantena added a subscriber: cmadeo.

From a technical level, it looks pretty straightforward to incorporate this information. In loadImage() on ShareViewController, we can also pull the owner from imageInfo, and use the same safety trimming on it we use elsewhere before displaying it.

@cmadeo Where do you envision this authorship information living on the Share-a-fact card? Here're a few recent featured/popular articles with the name that would be displayed included, of varying lengths:

shareafact_image.png (249×1 px, 213 KB)

  • Using the image author name directly on the image without providing context might not be desirable - for example, simply putting "Duncan.Hull" next to the image license might imply the photo is of "Duncan.Hull". Maybe some kind of "image by" type prefix alleviates some of this confusion?
  • While I believe I understand the intent of the "Made with the Wikipedia app" text, I wonder if there's a way to convey that without spelling it out. A way I've addressed this in the past has been just displaying the app icon itself. True, it certainly results in a less direct, more implied "app" though. Just wanted to mention this in thinking about what space the authorship label might occupy.

Thanks for these screenshots and framing @Dmantena! I agree with both of your points. We'll probably want to use the prefix of 'Image by' and your notion that it will be in conflict with the 'Made using the Wikipedia app' text makes a lot of sense. I'd like to check with @JMinor that it's okay to remove this string (from a design standpoint I think it makes sense, but I'd love to hear from Josh too!). Looking back at old mocks, here's a version that might work? Also I'd love to not include attribution if it's CC0 if that's okay.

03 transparent background .png (291×512 px, 52 KB)

LGoto added a subscriber: Dmantena.
cmadeo updated the task description. (Show Details)
cmadeo updated the task description. (Show Details)
LGoto added a subscriber: OTichonova.