Page MenuHomePhabricator

Add a link: triangle on link inspector has incorrect background color
Closed, ResolvedPublic

Description

Screen Shot 2021-04-27 at 2.31.26 PM.png (664×952 px, 161 KB)

In all cases, the triangle has the wrong color. It should match the link inspector's header.
The triangle is constructed using 2 pseudo elements: a white triangle in the foreground and a gray triangle for the border. Since this is constructed from stacked elements, the foreground element needs to have 100% opacity. Currently the background color value for the header is wmui-color-accent90 at 50% opacity so setting the same value won't work.

When the first annotation is selected, there's a transparent gray overlay covering the triangle. This goes away upon clicking outside of the annotation. The same overlay shows up while pressing previous/next button (video attached).

Screen Shot 2021-04-27 at 2.47.41 PM.png (1×1 px, 256 KB)

Event Timeline

mewoph updated the task description. (Show Details)

Change 683090 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: Update background color value for active annotation & triangle

https://gerrit.wikimedia.org/r/683090

Change 683090 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: Update background color value for active annotation & triangle

https://gerrit.wikimedia.org/r/683090

Etonkovidova claimed this task.