[Data Bridge][browser tests]Set appropriate timeouts for each waitFor* function
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	• Tonina_Zhelyazkova_WMDE
	Apr 28 2021, 9:38 AM

Description

After an investigation in T281122 it was decided that the data bridge browser tests which make API calls should have a timeout of 20s, so the "flakiness" of the tests in CI is reduced.
That was done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/682705

Not all data bridge browser tests which use a waitFor* function need to wait for 20s though.

Acceptance Criteria:🏕️🌟

Only the browser tests which make an API call should use the default timeout of 20s
The timeout in waitFor* functions which are not making API calls should be set on case-to-case basis

Interesting Links:

https://wmde.github.io/wikidata-wikibase-architecture/systems/WikibaseClient/06-Runtime_View.html#data-bridge

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	bridge: standardize timeouts in selenium tests	mediawiki/extensions/Wikibase	master	+34 -69

Customize query in gerrit

Related Objects

Mentioned In: T265596: Investigate and possibly improve stability of browser tests
Mentioned Here: T281122: Wikibase selenium tests timeout, seemingly due to "memory compaction" events on CI VMs

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Apr 28 2021, 9:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2021, 9:38 AM

• Tonina_Zhelyazkova_WMDE added projects: Wikidata, Wikidata-Campsite.Apr 28 2021, 9:38 AM

@Tonina_Zhelyazkova_WMDE just a heads up but I imagine this would be classed as a "small task" if you just wanted to dive in and do it?
I'm guessing, but I don't think this will end up getting prioritized super high using the scoring system (I could be wrong though also as it is low effort), but that would also be one of the reasons to allow it to skip the scoring session with the small task initiative in mind.

Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.May 4 2021, 10:51 AM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.May 4 2021, 10:54 AM

Addshore updated the task description. (Show Details)May 4 2021, 12:10 PM

darthmon_wmde updated the task description. (Show Details)May 5 2021, 9:33 AM

darthmon_wmde set the point value for this task to 5.May 5 2021, 9:36 AM

darthmon_wmde moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Addshore moved this task from Triaged Low (0-50) to Active on the [DEPRECATED] wdwb-tech board.May 5 2021, 10:04 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 5 2021, 10:15 AM

Michael claimed this task.May 18 2021, 1:18 PM

Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Michael. · View Herald TranscriptMay 18 2021, 1:18 PM

Change 692610 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] bridge: standardize timeouts in selenium tests

https://gerrit.wikimedia.org/r/692610

gerritbot added a project: Patch-For-Review.May 18 2021, 2:12 PM

Please also have a look at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/692615/ - that should be an easy +2

Change 692610 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] bridge: standardize timeouts in selenium tests

https://gerrit.wikimedia.org/r/692610

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 19 2021, 7:09 AM

Maintenance_bot removed a project: Patch-For-Review.May 19 2021, 7:10 AM

Addshore closed this task as Resolved.May 19 2021, 12:02 PM

Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 19 2021, 12:15 PM

Addshore mentioned this in T265596: Investigate and possibly improve stability of browser tests.Sep 14 2021, 8:40 AM

[Data Bridge][browser tests]Set appropriate timeouts for each waitFor* functionClosed, ResolvedPublic5 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[Data Bridge][browser tests]Set appropriate timeouts for each waitFor* function
Closed, ResolvedPublic5 Estimated Story Points
Actions