Page MenuHomePhabricator
Create Task
Maniphest T281341

Migrate TermInLangIdsResolver to service container
Closed, ResolvedPublic
Actions

Description

The TermInLangIdsResolver service in SingleEntitySourceServices should be migrated to the new service wiring files in repo and client respectively. This will allow us to stop passing a SingleEntitySourceServicesFactory into PrefetchingTermLookupFactory, and will finally allow us to remove the SingleEntitySourceServiceFactory service (T277731).

TermInLangIdsResolver is bound to one entity source, so the service we migrate should be a kind of TermInLangIdsResolverFactory, which is given an entity source (or its database name?) and returns a TermInLangIdsResolver.

Details

SubjectRepoBranchLines +/-
Remove getTermInLangIdsResolver from SingleEntitySourceServicesmediawiki/extensions/Wikibasemaster+0 -32
WikibaseRepo: Wire up TermInLangIdsFactory servicemediawiki/extensions/Wikibasemaster+63 -6
Create TermInLangIdsResolverFactorymediawiki/extensions/Wikibasemaster+159 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.Apr 28 2021, 9:51 AM
ItamarWMDE mentioned this in T281343: Stop Passing SingleEntitySourceServicesFactory into PrefetchingTermLookup callbacks.Apr 28 2021, 10:01 AM
ItamarWMDE claimed this task.May 3 2021, 8:36 AM
ItamarWMDE moved this task from Incoming to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T277731: WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServicesFactory Service.May 3 2021, 4:12 PM
gerritbot added a comment.May 3 2021, 5:10 PM

Change 684472 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Create TermInLangIdsResolverFactory

https://gerrit.wikimedia.org/r/684472

gerritbot added a project: Patch-For-Review.May 3 2021, 5:10 PM

Change 684473 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] WikibaseRepo: Wire up TermInLangIdsFactory service

https://gerrit.wikimedia.org/r/684473

gerritbot added a comment.May 3 2021, 5:10 PM

Change 684475 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Remove getTermInLangIdsResolver from SingleEntitySourceServices

https://gerrit.wikimedia.org/r/684475

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.May 3 2021, 5:13 PM
gerritbot added a comment.May 3 2021, 8:28 PM

Change 684472 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Create TermInLangIdsResolverFactory

https://gerrit.wikimedia.org/r/684472

gerritbot added a comment.May 4 2021, 9:35 AM

Change 684473 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] WikibaseRepo: Wire up TermInLangIdsFactory service

https://gerrit.wikimedia.org/r/684473

gerritbot added a comment.May 4 2021, 9:38 AM

Change 684475 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove getTermInLangIdsResolver from SingleEntitySourceServices

https://gerrit.wikimedia.org/r/684475

Lucas_Werkmeister_WMDE closed this task as Resolved.May 4 2021, 9:45 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 4 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 4 2021, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL