- I am an anonymous user
- Open the mobile view
- Hover a page preview
- Get into the settings using the cogwheel
- Disable page previews and hit save
- I get this window
Somehow the image is broken there (it seems to be very small).
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Suggestion: Let's do a quick git bisect and see if we find a specific patch that might be responsible for this.
Comment Actions
Change 683519 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix image size on footer link help screen
Comment Actions
According to my first git bisect in the Popups codebase this issue exists since the very first patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/571465/ (T236097, April 2020) that enabled Page-Previews on mobile.
Digging deeper reveals the patch https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/540479 in the mobile skin (T233521, October 2019). This introduced the background-size value that's responsible for this issue.
Either way, it's not a Regression but probably like this ever since.
Comment Actions
Fix works well for the image. There's still some misplacement with the text maybe it's equally easy to fix. See the images below.
Desktop
Mobile
Comment Actions
Change 683519 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix image size on footer link help screen
Comment Actions
Change 683573 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix image position on the settings dialog help screen
Comment Actions
Change 683573 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix image position on the settings dialog help screen