Page MenuHomePhabricator
Create Task
Maniphest T281361

TypeError: Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings::trackUsageForSitelink() must be an instance of Wikibase\DataModel\Entity\ItemId, instance of Wikibase\MediaInfo\DataMo
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
  • mwversion: 1.37.0-wmf.3
  • reqId: 83c857f3-6c84-4cc7-a8a8-a0bd99a536c9
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings::trackUsageForSitelink() must be an instance of Wikibase\DataModel\Entity\ItemId, instance of Wikibase\MediaInfo\DataMo
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php(293)
#0 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php(168): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings->trackUsageForSitelink(string, Wikibase\MediaInfo\DataModel\MediaInfoId)
#1 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(566): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings->getEntityId(string, string)
#2 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->getEntityId(string)
#3 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#4 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#5 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(296): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#6 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(68): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#7 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#8 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3356): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#9 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3041): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#10 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#11 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3230): PPFrame_Hash->expand(PPNode_Hash_Tree)
#12 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#13 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(2879): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#14 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(1549): Parser->replaceVariables(string)
#15 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(639): Parser->internalParse(string)
#16 /srv/mediawiki/php-1.37.0-wmf.3/includes/content/WikitextContent.php(375): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#17 /srv/mediawiki/php-1.37.0-wmf.3/includes/content/AbstractContent.php(591): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#18 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#19 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#20 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RevisionRenderer.php(232): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#21 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#22 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#23 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#24 /srv/mediawiki/php-1.37.0-wmf.3/includes/filerepo/file/LocalFile.php(2227): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#25 /srv/mediawiki/php-1.37.0-wmf.3/extensions/CommonsMetadata/src/DataCollector.php(290): LocalFile->getDescriptionText(LanguageEn)
#26 /srv/mediawiki/php-1.37.0-wmf.3/extensions/CommonsMetadata/src/DataCollector.php(98): CommonsMetadata\DataCollector->getDescriptionText(LocalFile, LanguageEn)
#27 /srv/mediawiki/php-1.37.0-wmf.3/extensions/CommonsMetadata/src/HookHandler.php(75): CommonsMetadata\DataCollector->collect(array, LocalFile)
#28 /srv/mediawiki/php-1.37.0-wmf.3/includes/HookContainer/HookContainer.php(330): CommonsMetadata\HookHandler::onGetExtendedMetadata(array, LocalFile, DerivativeContext, boolean, integer)
#29 /srv/mediawiki/php-1.37.0-wmf.3/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#30 /srv/mediawiki/php-1.37.0-wmf.3/includes/HookContainer/HookRunner.php(1886): MediaWiki\HookContainer\HookContainer->run(string, array)
#31 /srv/mediawiki/php-1.37.0-wmf.3/includes/media/FormatMetadata.php(1841): MediaWiki\HookContainer\HookRunner->onGetExtendedMetadata(array, LocalFile, DerivativeContext, boolean, integer)
#32 /srv/mediawiki/php-1.37.0-wmf.3/includes/media/FormatMetadata.php(1758): FormatMetadata->getExtendedMetadataFromHook(LocalFile, array, integer)
#33 /srv/mediawiki/php-1.37.0-wmf.3/extensions/CommonsMetadata/src/Hooks/SkinAfterBottomScriptsHandler.php(41): FormatMetadata->fetchExtendedMetadata(LocalFile)
#34 /srv/mediawiki/php-1.37.0-wmf.3/extensions/CommonsMetadata/src/HookHandler.php(243): CommonsMetadata\Hooks\SkinAfterBottomScriptsHandler->getSchemaElement(Title, LocalFile)
#35 /srv/mediawiki/php-1.37.0-wmf.3/extensions/CommonsMetadata/src/HookHandler.php(223): CommonsMetadata\HookHandler->doSkinAfterBottomScripts(LocalRepo, CommonsMetadata\Hooks\SkinAfterBottomScriptsHandler, Title)
#36 /srv/mediawiki/php-1.37.0-wmf.3/includes/HookContainer/HookContainer.php(330): CommonsMetadata\HookHandler::onSkinAfterBottomScripts(SkinVector, string)
#37 /srv/mediawiki/php-1.37.0-wmf.3/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#38 /srv/mediawiki/php-1.37.0-wmf.3/includes/HookContainer/HookRunner.php(3505): MediaWiki\HookContainer\HookContainer->run(string, array)
#39 /srv/mediawiki/php-1.37.0-wmf.3/includes/skins/Skin.php(764): MediaWiki\HookContainer\HookRunner->onSkinAfterBottomScripts(SkinVector, string)
#40 /srv/mediawiki/php-1.37.0-wmf.3/includes/skins/SkinMustache.php(387): Skin->bottomScripts()
#41 /srv/mediawiki/php-1.37.0-wmf.3/includes/skins/SkinMustache.php(144): SkinMustache->tailElement(OutputPage)
#42 /srv/mediawiki/php-1.37.0-wmf.3/includes/skins/SkinTemplate.php(146): SkinMustache->generateHTML()
#43 /srv/mediawiki/php-1.37.0-wmf.3/includes/OutputPage.php(2647): SkinTemplate->outputPage()
#44 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(930): OutputPage->output(boolean)
#45 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(943): MediaWiki::{closure}()
#46 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(550): MediaWiki->main()
#47 /srv/mediawiki/php-1.37.0-wmf.3/index.php(53): MediaWiki->run()
#48 /srv/mediawiki/php-1.37.0-wmf.3/index.php(46): wfIndexMain()
#49 /srv/mediawiki/w/index.php(3): require(string)
#50 {main}
Impact

Train blocker. Immediatle after promoting to group1, tens of thousands of these.

Notes

Details

Request URL
/w/api.php?format=json&formatversion=2&errorformat=plaintext&action=query&prop=imageinfo|imagelabels&iiprop=timestamp|user|url|mime|extmetadata&iiurlwidth=320&titles=File%3AAlexandre_Cabanel_004.jpg&iiextmetadatalanguage=en
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Lua: add unit test for `getEntityId` for non-itemsJakobmediawiki/extensions/Wikibasemaster+22 -1
Fix incorrect ItemId typehint in Lua bindingsAddshoremediawiki/extensions/Wikibasewmf/1.37.0-wmf.3+13 -13
Fix incorrect ItemId typehint in Lua bindingsJakobmediawiki/extensions/Wikibasemaster+13 -13
Revert "group1 wikis to 1.37.0-wmf.3"Lars Wirzeniusoperations/mediawiki-configmaster+524 -524
Customize query in gerrit

Related Objects
Search...

Event Timeline

• LarsWirzenius created this task.Apr 28 2021, 1:11 PM
• LarsWirzenius triaged this task as Unbreak Now! priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2021, 1:11 PM
• LarsWirzenius mentioned this in T278347: 1.37.0-wmf.3 deployment blockers.Apr 28 2021, 1:11 PM
Daimona added a project: Wikibase (3rd party installations).Apr 28 2021, 1:15 PM
Daimona subscribed.

Perhaps the intention was to use EntityId for the typehint instead?

Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptApr 28 2021, 1:15 PM
gerritbot added a comment.Apr 28 2021, 1:15 PM

Change 683276 had a related patch set uploaded (by Lars Wirzenius; author: Lars Wirzenius):

[operations/mediawiki-config@master] Revert "group1 wikis to 1.37.0-wmf.3"

https://gerrit.wikimedia.org/r/683276

gerritbot added a project: Patch-For-Review.Apr 28 2021, 1:15 PM

Change 683276 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group1 wikis to 1.37.0-wmf.3"

https://gerrit.wikimedia.org/r/683276

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2021, 2:10 PM
Raymond subscribed.Apr 28 2021, 2:14 PM
WMDE-leszek subscribed.Apr 28 2021, 3:00 PM
Addshore subscribed.Apr 28 2021, 3:01 PM
Lucas_Werkmeister_WMDE subscribed.EditedApr 28 2021, 3:02 PM
In T281361#7041839, @Daimona wrote:

Perhaps the intention was to use EntityId for the typehint instead?

trackUsageForSitelink() does not sound like a method that should encounter other types of entity IDs (only items can have sitelinks).

Addshore added a project: CommonsMetadata.EditedApr 28 2021, 3:03 PM

I'm suspicious of this CommonsMetadata extension and what exactly it is doing.

Addshore added a subscriber: Tgr.Apr 28 2021, 3:06 PM
• Tonina_Zhelyazkova_WMDE subscribed.Apr 28 2021, 3:09 PM
Addshore added a comment.Apr 28 2021, 3:11 PM

Scanned logstash and found an occurrence on test-commons too.

https://test-commons.wikimedia.org/wiki/File:Godward_Idleness_1900-dupe!.jpg

Argument 2 passed to Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings::trackUsageForSitelink() must be an instance of Wikibase\DataModel\Entity\ItemId, instance of Wikibase\MediaInfo\DataModel\MediaInfoId given, called in /srv/mediawiki/php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php on line 168

from /srv/mediawiki/php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php(293)
#0 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php(168): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings->trackUsageForSitelink(string, Wikibase\MediaInfo\DataModel\MediaInfoId)
#1 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(566): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageIndependentLuaBindings->getEntityId(string, string)
#2 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->getEntityId(string)
#3 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#4 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#5 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(296): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#6 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(68): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#7 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#8 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3356): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#9 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3041): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#10 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#11 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3230): PPFrame_Hash->expand(PPNode_Hash_Tree)
#12 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#13 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPTemplateFrame_Hash.php(97): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#14 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3227): PPTemplateFrame_Hash->cachedExpand(string, PPNode_Hash_Tree)
#15 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#16 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPTemplateFrame_Hash.php(178): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#17 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPTemplateFrame_Hash.php(190): PPTemplateFrame_Hash->getNamedArgument(string)
#18 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPTemplateFrame_Hash.php(121): PPTemplateFrame_Hash->getArgument(string)
#19 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(696): PPTemplateFrame_Hash->getArguments()
#20 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Scribunto_LuaEngine->getAllExpandedArguments(string)
#21 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#22 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#23 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(296): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#24 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(68): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#25 /srv/mediawiki/php-1.37.0-wmf.3/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#26 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3356): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#27 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3041): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#28 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#29 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(3230): PPFrame_Hash->expand(PPNode_Hash_Tree)
#30 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#31 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(2879): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#32 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(1549): Parser->replaceVariables(string)
#33 /srv/mediawiki/php-1.37.0-wmf.3/includes/parser/Parser.php(639): Parser->internalParse(string)
#34 /srv/mediawiki/php-1.37.0-wmf.3/includes/content/WikitextContent.php(375): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#35 /srv/mediawiki/php-1.37.0-wmf.3/includes/content/AbstractContent.php(591): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#36 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#37 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#38 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RevisionRenderer.php(232): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#39 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#40 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#41 /srv/mediawiki/php-1.37.0-wmf.3/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#42 /srv/mediawiki/php-1.37.0-wmf.3/includes/poolcounter/PoolWorkArticleView.php(137): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#43 /srv/mediawiki/php-1.37.0-wmf.3/includes/poolcounter/PoolCounterWork.php(162): PoolWorkArticleView->doWork()
#44 /srv/mediawiki/php-1.37.0-wmf.3/includes/page/ParserOutputAccess.php(281): PoolCounterWork->execute()
#45 /srv/mediawiki/php-1.37.0-wmf.3/includes/page/Article.php(763): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiFilePage, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, integer)
#46 /srv/mediawiki/php-1.37.0-wmf.3/includes/page/Article.php(575): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#47 /srv/mediawiki/php-1.37.0-wmf.3/includes/page/ImagePage.php(153): Article->view()
#48 /srv/mediawiki/php-1.37.0-wmf.3/includes/actions/ViewAction.php(74): ImagePage->view()
#49 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(535): ViewAction->show()
#50 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(319): MediaWiki->performAction(ImagePage, Title)
#51 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(916): MediaWiki->performRequest()
#52 /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php(550): MediaWiki->main()
#53 /srv/mediawiki/php-1.37.0-wmf.3/index.php(53): MediaWiki->run()
#54 /srv/mediawiki/php-1.37.0-wmf.3/index.php(46): wfIndexMain()
#55 /srv/mediawiki/w/index.php(3): require(string)
#56 {main}
Lucas_Werkmeister_WMDE added a comment.EditedApr 28 2021, 3:11 PM

Hm, this bit in WikibaseLanguageIndependentLuaBindings::getEntityId() looks very suspicious:

		if ( $globalSiteId === $this->siteId ) {
			$title = Title::newFromDBkey( $pageTitle );
			if ( $title !== null ) {
				$itemId = $this->entityIdLookup->getEntityIdForTitle( $title );
			}
		}

Surely getEntityIdForTitle() can return non-item IDs? Even on Wikidata (property IDs)?

Jakob_WMDE subscribed.Apr 28 2021, 3:12 PM
Addshore removed a project: CommonsMetadata.Apr 28 2021, 3:13 PM
Addshore removed a subscriber: Tgr.
Jakob_WMDE claimed this task.Apr 28 2021, 3:19 PM

I think I found the problem and will upload a patch in a bit. (That type hint for the extracted method in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/681583 looks very wrong in hindsight)

gerritbot added a comment.Apr 28 2021, 3:34 PM

Change 683361 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Fix incorrect ItemId typehint in Lua bindings

https://gerrit.wikimedia.org/r/683361

gerritbot added a project: Patch-For-Review.Apr 28 2021, 3:34 PM
Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.Apr 28 2021, 3:40 PM
Tgr added a comment.Apr 28 2021, 4:03 PM
In T281361#7042295, @Addshore wrote:

I'm suspicious of this CommonsMetadata extension and what exactly it is doing.

It's parsing the file description page to extract microdata-style file metadata. It's triggered in a weird way (any time a request for metadata results in a cache miss, here it seems to be called from the SkinAfterBottomScripts hook to generate the JSON-LD metadata wanted by Google Image Search) but otherwise it should be a normal parse.

gerritbot added a comment.Apr 28 2021, 4:11 PM

Change 683143 had a related patch set uploaded (by Addshore; author: Jakob):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.3] Fix incorrect ItemId typehint in Lua bindings

https://gerrit.wikimedia.org/r/683143

gerritbot added a comment.Apr 28 2021, 4:37 PM

Change 683361 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix incorrect ItemId typehint in Lua bindings

https://gerrit.wikimedia.org/r/683361

gerritbot added a comment.Apr 28 2021, 4:46 PM

Change 683377 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Lua: add unit test for `getEntityId` for non-items

https://gerrit.wikimedia.org/r/683377

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 28 2021, 5:00 PM
gerritbot added a comment.Apr 28 2021, 5:06 PM

Change 683143 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.3] Fix incorrect ItemId typehint in Lua bindings

https://gerrit.wikimedia.org/r/683143

Stashbot added a comment.Apr 28 2021, 5:12 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-28T17:11:57Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.3/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php: rEWBAb392dba0d779: Fix incorrect ItemId typehint in Lua bindings (T281361) (duration: 01m 09s)

ReleaseTaggerBot edited projects, added: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 28 2021, 6:00 PM
Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.Apr 28 2021, 6:51 PM
Jdforrester-WMF subscribed.Apr 29 2021, 1:17 AM

Is this Resolved?

Jakob_WMDE closed this task as Resolved.Apr 29 2021, 7:44 AM
In T281361#7044266, @Jdforrester-WMF wrote:

Is this Resolved?

Yup!

gerritbot added a comment.Apr 30 2021, 4:39 PM

Change 683377 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Lua: add unit test for `getEntityId` for non-items

https://gerrit.wikimedia.org/r/683377

ReleaseTaggerBot edited projects, added: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04); removed: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 30 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 30 2021, 5:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits