Page MenuHomePhabricator

Storybook: Question mark icons are confusingly represented for certain RTL langs
Closed, ResolvedPublic

Description

Problem Statement

Some RTL languages mirror question marks, a few (he and yi) don't. Current Storybook represents them as one singular visual group, in contrast to for example wvuiIconBold* ones.

OOUI uses one-direction question mark containing icons for RTL languages, with exception of he and yi.
WVUI is falsely mirroring them for all languages, specifically problematic on this is Hebrew mispresenting this in Storybook for exceptions of shouldFlip (example: 'wvuiIconHelp') in the way it's done for language variants ('IconVariedByLang').

image.png (248×770 px, 24 KB)


Side-note, having SVG files in repo would have made this simpler discoverable (diffing).

Event Timeline

Volker_E renamed this task from Question mark icons are wrongly mirrored for all RTL langs to Storybook: Question mark icons are confusingly represented for all RTL langs.Apr 28 2021, 1:40 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
Volker_E added a subscriber: Catrope.
Volker_E renamed this task from Storybook: Question mark icons are confusingly represented for all RTL langs to Storybook: Question mark icons are confusingly represented for certain RTL langs.Apr 29 2021, 2:46 PM
Volker_E updated the task description. (Show Details)

Change 691360 had a related patch set uploaded (by Catrope; author: Catrope):

[wvui@master] [storybook][icon] List languages from shouldFlipExceptions

https://gerrit.wikimedia.org/r/691360

With this patch:

Screenshot from 2021-05-14 18-08-12.png (191×349 px, 23 KB)

Side-note, having SVG files in repo would have made this simpler discoverable (diffing).

I don't think so, because these are automatically-flipped icons. Even if we had SVG files in the repo, there would not have been a separate SVG file for the RTL version of the help icon. The SVG files would also not have told you about the special treatment Hebrew and Yiddish get for these icons.

Change 691360 merged by jenkins-bot:

[wvui@master] [storybook][icon] List languages from shouldFlipExceptions

https://gerrit.wikimedia.org/r/691360

You're mostly right. For some reason I was making up a visual lookup process in my brain towards differently labelled icons on example help.
When going through icon OOUI JSON files the -ltr/-rtl SVGs are assigned to certain language ISO code keys. Then I was sometimes looking up the specific icon in the folder and just visualized it.

In case of more complex ones, where the LTR/RTL icons are not reused, like bold, the SVGs carry the lang code in the file name, like bold-cyrl-te.svg.
This doesn't make the comparison much simpler, but should explain partly my thought process above. Nevertheless, we want to have as lil duplicate icons as files or paths in the document for maintenance and therefore having a dedicated comparison in Storybook for all specific languages is superior solution. :)

Change 697700 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update wvui to 0.2.0

https://gerrit.wikimedia.org/r/697700

Change 697700 merged by jenkins-bot:

[mediawiki/core@master] Update wvui to 0.2.0

https://gerrit.wikimedia.org/r/697700