The author or submitter of a patch that would need promoting in deployment charts doesn't get a notification that a patch has been created. Add the author and the submitter as a reviewer to the promote patch that gets created for deployment-charts.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add patch author/reviewer to promote patch | integration/pipelinelib | master | +310 -56 |
Event Timeline
Comment Actions
Change 719319 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):
[integration/pipelinelib@master] WIP add patch author as reviewer to promote patch
Comment Actions
Change 719319 merged by jenkins-bot:
[integration/pipelinelib@master] Add patch author/reviewer to promote patch
Comment Actions
see https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/720384 for example of added reviewers
Comment Actions
I noticed this as part of https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/720980 - while well intentioned, I'm not sure it makes sense for some or most services. The person reviewing the deployment-charts patch should be the service owner/deployer, which is not necessarily the person who wrote the patch. I think it would be better for deployers to set them to auto-review deployments-charts patches that match their service via [[mw:Git/Reviewers]] or similar.
At the very least it would be nice if there was a way to opt-out of this behavior.
Comment Actions
Thanks for your feedback @Legoktm. We can definitely re-think how this should work.
Maybe having pipelinebot comment on the merged patch with a link to the deployment-charts patch would be sufficient as notification.