Page MenuHomePhabricator
Create Task
Maniphest T281408

small fixes to community prototype
Closed, ResolvedPublic
Actions

Description

Description

We're currently using this prototype to collect feedback from community members. There are a few small issues we would like to fix before the next round of feedback.

To do

  • add the Table of contents
  • ensure that infoboxes display at standard width (270px)
  • add Edit tab next between Read and View/Edit source tabs in article toolbar
  • ensure article content area is centered on the screen for larger screens (currently at a browser width of 1401px it jumps a bit to the right and remains uncentered)

Event Timeline

• alexhollender_WMF created this task.Apr 28 2021, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2021, 7:45 PM
ovasileva triaged this task as High priority.Apr 29 2021, 10:28 AM
ovasileva removed Jdrewniak as the assignee of this task.May 3 2021, 10:10 AM
ovasileva moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
ovasileva added a subscriber: Jdrewniak.
ovasileva assigned this task to Jdrewniak.May 3 2021, 5:36 PM
LGoto moved this task from Upcoming to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 3 2021, 5:36 PM
Jdrewniak added a comment.May 4 2021, 10:38 AM

@alexhollender As of this writing the fixes are live. I've circled them on this screenshot, passing over to you to verify.
One other thing that I changed is that I unwittingly used the "system" font stack in the prototype and forgot about that,
but then someone on the discussion page pointed that out, in all-caps, so I changed it to "sans-serif" as it is in production.

Screen Shot 2021-05-04 at 12.22.05 PM.png (1×3 px, 893 KB)

Jdrewniak moved this task from Doing to Design Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 4 2021, 11:31 AM
Jdrewniak removed Jdrewniak as the assignee of this task.May 4 2021, 12:57 PM
sgrabarczuk subscribed.May 4 2021, 3:22 PM

Jan, would you be able to make fixes on German as well?

LGoto assigned this task to • alexhollender_WMF.May 4 2021, 5:13 PM
• alexhollender_WMF reassigned this task from • alexhollender_WMF to Jdrewniak.May 4 2021, 5:50 PM
• alexhollender_WMF moved this task from Design Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

looking great in general!

In T281408#7058066, @sgrabarczuk wrote:

Jan, would you be able to make fixes on German as well?

@sgrabarczuk great catch : )

@Jdrewniak to clarify: some infoboxes (like the one on the German "Moon" article) are not being floated, therefore they are appearing above the lead paragraph. As discussed let's target those and float them right since German and English are both LTR and those are our priorities for now.

Jdrewniak added a comment.May 6 2021, 9:54 AM

@sgrabarczuk @alexhollender Ok looks like all that was missing was the float-right/left styles. German "Moon" article looks better now.

Jdrewniak reassigned this task from Jdrewniak to • alexhollender_WMF.May 6 2021, 1:01 PM
Jdrewniak moved this task from Needs More Work to Design Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
• alexhollender_WMF reassigned this task from • alexhollender_WMF to sgrabarczuk.May 6 2021, 7:21 PM
• alexhollender_WMF moved this task from Design Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

@Jdrewniak awesome, looks great. @sgrabarczuk would you like to do one final inspection before we put the banners up?

sgrabarczuk closed this task as Resolved.May 10 2021, 7:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL