⚓ T281457 Several Wikibase services try to read from local domain, when they mean to access the repo

Subject	Repo	Branch	Lines +/-
EntityChangeLookup: Pass domain to ILoadBalancer::getConnectionRef	mediawiki/extensions/Wikibase	master	+23 -5
Add repoWiki to WikiPageEntityMetaDataLookup	mediawiki/extensions/Wikibase	master	+10 -5
SiteLinkTable: Pass domain to ILoadBalancer::getConnectionRef	mediawiki/extensions/Wikibase	master	+21 -7

Status	Subtype	Assigned	Task
Resolved		hoo	T281457 Several Wikibase services try to read from local domain, when they mean to access the repo
Resolved	BUG REPORT	hoo	T281450 Exception: Table 'enwiki.wb_items_per_site' doesn't exist
Resolved		hoo	T281446 unbreak the pipeline

hoo created this task.Apr 29 2021, 10:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2021, 10:04 AM

hoo triaged this task as Unbreak Now! priority.Apr 29 2021, 10:04 AM

hoo added a subtask: T281450: Exception: Table 'enwiki.wb_items_per_site' doesn't exist.

hoo added a subtask: T281446: unbreak the pipeline.

hoo claimed this task.Apr 29 2021, 10:08 AM

Jakob_WMDE subscribed.Apr 29 2021, 10:13 AM

Addshore subscribed.Apr 29 2021, 10:15 AM

hoo updated the task description. (Show Details)Apr 29 2021, 10:26 AM

Addshore added a project: [DEPRECATED] wdwb-tech.Apr 29 2021, 10:31 AM

Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.

Change 683575 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Add repoWiki to WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/683575

Change 683574 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] SiteLinkTable: Pass domain to ILoadBalancer::getConnectionRef

https://gerrit.wikimedia.org/r/683574

Change 683561 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] EntityChangeLookup: Pass domain to ILoadBalancer::getConnectionRef

https://gerrit.wikimedia.org/r/683561

Tarrow updated the task description. (Show Details)Apr 29 2021, 10:38 AM

hoo updated the task description. (Show Details)Apr 29 2021, 10:44 AM

Ladsgroup subscribed.Apr 29 2021, 10:45 AM

Maintenance_bot added a project: Wikidata.Apr 29 2021, 10:45 AM

Audit git diff origin/wmf/1.37.0-wmf.3..HEAD for getConnection/getConnectionRef related changes.

Probably also a good idea to look through the subtasks of T279063, I don’t remember if all of those were only merged after the wmf.3 branch cut. (Edit: it looks like they were, SqlSiteLinkLookup was the first one and that already came after wmf.3.)

Looks like a comprehensive list to me too

I just grepped git diff origin/wmf/1.36.0-wmf.30..origin/wmf/1.37.0-wmf.3 client/ lib/ data-access/ as well and that seems to contain no further relevant changes, so once the three mentioned at the top are addressed we should be good here.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Apr 29 2021, 11:15 AM

Change 683574 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] SiteLinkTable: Pass domain to ILoadBalancer::getConnectionRef

https://gerrit.wikimedia.org/r/683574

hoo updated the task description. (Show Details)Apr 29 2021, 11:25 AM

Change 683575 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add repoWiki to WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/683575

hoo updated the task description. (Show Details)Apr 29 2021, 11:32 AM

hoo closed subtask T281450: Exception: Table 'enwiki.wb_items_per_site' doesn't exist as Resolved.

hoo moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 683561 merged by jenkins-bot: