Page MenuHomePhabricator

Several Wikibase services try to read from local domain, when they mean to access the repo
Closed, ResolvedPublic

Event Timeline

Change 683575 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Add repoWiki to WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/683575

Change 683574 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] SiteLinkTable: Pass domain to ILoadBalancer::getConnectionRef

https://gerrit.wikimedia.org/r/683574

Change 683561 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] EntityChangeLookup: Pass domain to ILoadBalancer::getConnectionRef

https://gerrit.wikimedia.org/r/683561

Audit git diff origin/wmf/1.37.0-wmf.3..HEAD for getConnection/getConnectionRef related changes.

Probably also a good idea to look through the subtasks of T279063, I don’t remember if all of those were only merged after the wmf.3 branch cut. (Edit: it looks like they were, SqlSiteLinkLookup was the first one and that already came after wmf.3.)

Looks like a comprehensive list to me too

I just grepped git diff origin/wmf/1.36.0-wmf.30..origin/wmf/1.37.0-wmf.3 client/ lib/ data-access/ as well and that seems to contain no further relevant changes, so once the three mentioned at the top are addressed we should be good here.

Change 683574 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] SiteLinkTable: Pass domain to ILoadBalancer::getConnectionRef

https://gerrit.wikimedia.org/r/683574

Change 683575 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add repoWiki to WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/683575

Change 683561 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] EntityChangeLookup: Pass domain to ILoadBalancer::getConnectionRef

https://gerrit.wikimedia.org/r/683561