Page MenuHomePhabricator

Prevent link suggestions from appearing again after publishing an edit
Closed, ResolvedPublic

Description

As noted in T278600: Pre-deployment QA: "Add a link":

@Etonkovidova :

  1. When you apply a link and on the second attempt if you then select "No", it does not remove the previously applied link.

Do you mean that "No" button doesn't act as a toggle?

Not exactly. It actually does act like a toggle on the same session, as in when you click on it again on the same session it sets the status of that suggestion to unchanged which is denoted by "-" on the save dialog it seems. The issue I am describing here happens when you already applied a link and submitted your changes, then re-opened the article again and going through the same link suggestion again. If at that point, you click "No" on the link suggestion dialog, it does not remove the actual link whereas on the save dialog it shows 'x" for it. Does that make sense? :) Also, noticed that it doesn't remember the previous state of the buttons on the link suggestion dialog in the next edit session.

After the save, we should delete taskData from the suggested edit session, or end the suggested edit session. We might want to handle that in T269659: Add a link: post-edit dialog

Event Timeline

T269659 will probably involve adding a state flag to the suggested edit session (since it needs to differentiate between a real edit and a null edit). So it seems like a good place to handle this, one way or another.

Change 683853 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Prevent suggestions mode from loading after exiting post-edit dialog

https://gerrit.wikimedia.org/r/683853

Change 683853 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Prevent suggestions mode from loading after exiting post-edit dialog

https://gerrit.wikimedia.org/r/683853

Checked in testwiki wmf.5.