Page MenuHomePhabricator
Create Task
Maniphest T281463

Set background color to recommended link context item
Closed, ResolvedPublic
Actions

Description

As noted in T278600: Pre-deployment QA: "Add a link":

The blue-highlight for different elements present on the article page can overlap with the adjacent link suggestion context menu.

screenshot 1.png (1,992×1,110 px, 394 KB)

screenshot 2.png (1,414×760 px, 265 KB)

Note that the issue with the first screenshot will be solved by T280129: Disable interactions with all context items except for RecommendedLinkContextItem

Related Objects

Event Timeline

kostajh created this task.Apr 29 2021, 10:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2021, 10:45 AM
kostajh triaged this task as Medium priority.Apr 29 2021, 10:45 AM
kostajh moved this task from Backlog to April 26 - April 30 on the Add-Link-Structured-Task board.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh mentioned this in T278600: Pre-deployment QA: "Add a link".
Tgr subscribed.Apr 29 2021, 12:03 PM

Possibly a duplicate of T280129: Disable interactions with all context items except for RecommendedLinkContextItem - the blue overlay only shows up when hovering over the infobox, so if interactions are disabled it might not show up at all.

kostajh changed the task status from Open to Stalled.Apr 29 2021, 12:05 PM
kostajh moved this task from April 26 - April 30 to Backlog on the Add-Link-Structured-Task board.
kostajh removed a project: Growth-Team (Sprint 0 (Growth Team)).
In T281463#7045337, @Tgr wrote:

Possibly a duplicate of T280129: Disable interactions with all context items except for RecommendedLinkContextItem - the blue overlay only shows up when hovering over the infobox, so if interactions are disabled it might not show up at all.

Ah right, marking as stalled until we do T280129 and then we can re-check this.

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 29 2021, 12:05 PM
kostajh changed the task status from Stalled to Open.May 3 2021, 5:55 PM
kostajh edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.
kostajh moved this task from Backlog to May 3 - May 7 on the Add-Link-Structured-Task board.
kostajh merged a task: T281648: Add link: VE elements overlapping context item on desktop.
kostajh added subscribers: Etonkovidova, • mewoph, MMiller_WMF.
kostajh assigned this task to • mewoph.May 3 2021, 6:00 PM

@mewoph would you mind taking a look at this? It might not be an issue anymore. See also the screenshots in T281648: Add link: VE elements overlapping context item on desktop

• mewoph merged a task: T280129: Disable interactions with all context items except for RecommendedLinkContextItem.May 3 2021, 11:28 PM
• mewoph added subscribers: ppelberg, RHo.

With changes for T280129: Disable interactions with all context items except for RecommendedLinkContextItem, this issue is not reproducible.

• mewoph moved this task from Ready for Development to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 3 2021, 11:29 PM
• mewoph moved this task from May 3 - May 7 to Done / QA on the Add-Link-Structured-Task board.
Etonkovidova closed this task as Resolved.May 12 2021, 1:16 AM

Re-checked in betalabs - there are no interactions with the articles' elements anymore, so the issue is solved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits