Page MenuHomePhabricator

Add support for Wikiset changes
Closed, ResolvedPublic

Description

As noticed in irc, stewardbot doesn't support wikiset changes. This should be added.

Event Timeline

I'm gonna take a look into this.

Change 687007 had a related patch set uploaded (by Zabe; author: Zabe):

[labs/tools/stewardbots@master] StewardBot: add support for wikisets

https://gerrit.wikimedia.org/r/687007

Change 687007 merged by Urbanecm:

[labs/tools/stewardbots@master] StewardBot: add support for wikisets

https://gerrit.wikimedia.org/r/687007

@Zabe I deployed your change. It works, but it would be even nicer with one change, see below:

18:35 <@StewardBot> Martin Urbanec created the new optin wikiset Testset containing testwiki, test2wiki: this is a test
18:35 <+Urbanecm> dont|panic: it sounds it works^^
18:36 <@StewardBot> Martin Urbanec changed wikis in Testset, added testcommonswiki, removed : add testcommonswiki
18:36 <@StewardBot> Martin Urbanec changed wikis in Testset, added , removed testwiki, testcommonswiki: tests
18:36 <+dont|panic> cool :D
18:36 <@StewardBot> Martin Urbanec deleted wikiset Testset: undo test
18:36 <+dont|panic> maybe we could fix the blanks where it didn't change
18:37 <+Urbanecm> yeah

Could you implement that one as well please? :-)

Change 687210 had a related patch set uploaded (by Zabe; author: Zabe):

[labs/tools/stewardbots@master] StewardBot: fix wikiset messages

https://gerrit.wikimedia.org/r/687210

@Zabe I deployed your change. It works, but it would be even nicer with one change, see below:

18:35 <@StewardBot> Martin Urbanec created the new optin wikiset Testset containing testwiki, test2wiki: this is a test
18:35 <+Urbanecm> dont|panic: it sounds it works^^
18:36 <@StewardBot> Martin Urbanec changed wikis in Testset, added testcommonswiki, removed : add testcommonswiki
18:36 <@StewardBot> Martin Urbanec changed wikis in Testset, added , removed testwiki, testcommonswiki: tests
18:36 <+dont|panic> cool :D
18:36 <@StewardBot> Martin Urbanec deleted wikiset Testset: undo test
18:36 <+dont|panic> maybe we could fix the blanks where it didn't change
18:37 <+Urbanecm> yeah

Could you implement that one as well please? :-)

@Urbanecm I uploaded a follow-up patch. :)

Change 687210 merged by jenkins-bot:

[labs/tools/stewardbots@master] StewardBot: improve wiki set messages

https://gerrit.wikimedia.org/r/687210