Page MenuHomePhabricator

Add a link: virtual keyboard covers the link inspector on mobile
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable link recommendations
  • Click on task card from Special:Homepage
  • Click on a recommendation

What happens?:
The virtual keyboard covers the link inspector.

What should have happened instead?:
Keyboard should not appear since the user can't edit the text.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

IMG_1521.PNG (2×1 px, 920 KB)

Event Timeline

mewoph moved this task from Backlog to April 26 - April 30 on the Add-Link board.
mewoph moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.

Change 683729 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: fixes for RecommendedLinkToolbarDialog's scrolling and keyboard issues

https://gerrit.wikimedia.org/r/683729

The patch addresses the issue where the keyboard shows up when navigating between recommendations using buttons in the link inspector.

However, when the recommendation is tapped, the keyboard appears and then is dismissed.

Another issue w/keyboard: when tapping on anywhere in the surface (outside of the recommended link annotations), the keyboard shows up and the link inspector is pushed towards the top of the screen (whereas with the default context item, tapping outside the link inspector should dismiss it)

IMG_1526.PNG (2×1 px, 963 KB)

Is this happening just on iOS or also for Android? cc @Etonkovidova

Change 683729 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: fixes for RecommendedLinkToolbarDialog's scrolling and keyboard issues

https://gerrit.wikimedia.org/r/683729

Is this happening just on iOS or also for Android? cc @Etonkovidova

The issue has been fixed.
However, there are another scrolling effect - click on the add link itself, the screen rolls up, and some options appear such as "Select", "Share" etc. I remember that @mewoph mentioned it, but I could not find the task, so I filed T282635: [mobile] Add link-clicking on a link forces page to scroll