ResourceLoaderSkinModule: Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecated
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 29 2021, 11:57 PM

Description

NOTE: The deprecation patch can be merged once T287410 is resolved. This completes the technical goal of T282045

In T89981 we split out the legacy feature (ResourceLoaderSkinModule) into multiple parts.
In T287410 we disabled its usage across all skins.

As part of the change we should also deprecate the content feature and content-thumbnails feature which currently act as aliases for other modules.

legacy has been split up by no direct replacement
content got superseded by content-media
content-thumbnails got superseded by content-media

TODO

skins that use the legacy option should send a deprecation warning to the JavaScript console. This will need to be sent inside ResourceLoaderSkinModule
skins that use the legacy option should send a deprecation warning to the JavaScript console. This will need to be sent inside ResourceLoaderSkinModule
Update docs/uidesign/design.html to include the appropriate styles once legacy is removed.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T282045 [GOAL] Deprecate and remove skin code in preparation for 1.37
		Resolved		Jdlrobson	T281542 ResourceLoaderSkinModule: Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecated

Event Timeline

Jdlrobson created this task.Apr 29 2021, 11:57 PM

Jdlrobson updated the task description. (Show Details)Apr 30 2021, 12:17 AM

Jdlrobson mentioned this in T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.

I think I'm just going to start including a fork of the 1.34 shared.css with my skins instead.

Isarra removed a project: Timeless.Apr 30 2021, 3:38 AM

Jdlrobson awarded a token.May 4 2021, 9:00 PM

Jdlrobson mentioned this in T250688: Timeless skin search box is forced to LTR direction on LTR sites even when user interface language is RTL.May 19 2021, 5:44 PM

Jdlrobson triaged this task as Medium priority.Jun 25 2021, 8:51 PM

Jdlrobson updated the task description. (Show Details)Jun 25 2021, 8:55 PM

Jdlrobson added a parent task: T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task from Incoming to unsed on the Web-Team-Backlog board.

Jdlrobson moved this task from Backlog to Tech debt on the MonoBook board.Jul 1 2021, 11:04 PM

Jdlrobson moved this task from unsed to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.Jul 20 2021, 7:02 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.

Jdlrobson moved this task from Kanbanana-FY-2020-21 to unsed on the Web-Team-Backlog board.

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2020-21).

Change 655170 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] ResourceLoaderSkinModule: The `content` and `legacy` features are deprecated

https://gerrit.wikimedia.org/r/655170

gerritbot added a project: Patch-For-Review.Jul 22 2021, 6:47 PM

Jdlrobson renamed this task from Mark the ResourceLoaderSkinModule `legacy` feature as deprecated to Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecated.Jul 22 2021, 6:52 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from unsed to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.Jul 23 2021, 8:08 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson updated the task description. (Show Details)Jul 26 2021, 8:14 PM

Jdlrobson renamed this task from Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecated to ResourceLoaderSkinModule: Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecatedå.Jul 26 2021, 8:18 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2020-21).

Jdlrobson moved this task from Incoming to unsed on the Web-Team-Backlog board.

Jdlrobson renamed this task from ResourceLoaderSkinModule: Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecatedå to ResourceLoaderSkinModule: Mark the ResourceLoaderSkinModule `legacy` and `content` features as deprecated.Jul 28 2021, 10:03 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.Jul 28 2021, 10:39 PM

Jdlrobson removed projects: Vector (legacy skin), MonoBook, CologneBlue, Modern.Jul 29 2021, 5:13 PM

Jdlrobson updated the task description. (Show Details)

LGoto set the point value for this task to 2.Jul 29 2021, 5:15 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 29 2021, 5:36 PM

LGoto edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Kanbanana-FY-2020-21).Aug 2 2021, 9:27 PM

LGoto moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson claimed this task.Aug 3 2021, 5:00 PM

Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.