Page MenuHomePhabricator
Create Task
Maniphest T281559

Implement new Content Translation data collection for Section Translation
Closed, ResolvedPublic
Actions

Description

We want to instrument the section translation workflow using the new content_translation_event schema. For instructions and documentation, see the parent task (T281973).

Doing focused QA is important for this task, since issues in the events we capture will result in unreliable/misleading data.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20221212mediawiki/extensions/ContentTranslationmaster+61 -28
Add event logging: editor_segment_addmediawiki/extensions/ContentTranslationmaster+41 -8
CX3 Build 0.2.0+20221107mediawiki/extensions/ContentTranslationmaster+846 -428
CXSuggestionList: Add event logging when suggestions are refreshedmediawiki/extensions/ContentTranslationmaster+9 -1
CX3 Build 0.1.0+20211108mediawiki/extensions/ContentTranslationmaster+6 -6
SXTranslationConfirmer: Move translation start event logging heremediawiki/extensions/ContentTranslationmaster+13 -12
CXSuggestionList: Add event loggingmediawiki/extensions/ContentTranslationmaster+17 -2
SX Search for article: Add event loggingmediawiki/extensions/ContentTranslationmaster+59 -26
SX Eventlogging: Fetch global edit count for the usermediawiki/extensions/ContentTranslationmaster+124 -23
Section translation Eventlogging instrumentationmediawiki/extensions/ContentTranslationmaster+79 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Apr 30 2021, 9:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2021, 9:56 AM
Pginer-WMF triaged this task as Medium priority.Apr 30 2021, 9:56 AM
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2021-April-June) board.
Pginer-WMF moved this task from Backlog to General infrastructure on the SectionTranslation board.
Pginer-WMF raised the priority of this task from Medium to High.Apr 30 2021, 9:58 AM
nshahquinn-wmf merged a task: T266569: Implement new Content Translation event logging in mobile version.May 4 2021, 3:26 PM
nshahquinn-wmf added a parent task: T231316: Collect data on all key Content Translation user flows.
nshahquinn-wmf added a subscriber: santhosh.
Pginer-WMF added a parent task: T266569: Implement new Content Translation event logging in mobile version.May 5 2021, 9:31 AM
nshahquinn-wmf renamed this task from Implement instrumentation support for Section Translation to Implement new Content Translation data collection for Section Translation.May 5 2021, 12:32 PM
nshahquinn-wmf edited parent tasks, added: T281973: Implement new Content Translation data collection; removed: T266569: Implement new Content Translation event logging in mobile version, T231316: Collect data on all key Content Translation user flows.
nshahquinn-wmf updated the task description. (Show Details)May 5 2021, 1:20 PM
gerritbot added a comment.May 6 2021, 1:06 PM

Change 685760 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Section translation Eventlogging instrumentation

https://gerrit.wikimedia.org/r/685760

gerritbot added a project: Patch-For-Review.May 6 2021, 1:06 PM
santhosh moved this task from Priority Backlog to In Progress on the Language-Team (Language-2021-April-June) board.May 25 2021, 5:36 AM

The schema need some changes to accommodate anonymous users too. Section translation will support anonymous translation(T278942). Waiting for @nshahquinn-wmf for that.

gerritbot added a comment.May 25 2021, 10:27 AM

Change 685760 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Section translation Eventlogging instrumentation

https://gerrit.wikimedia.org/r/685760

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).May 25 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 25 2021, 11:10 AM
nshahquinn-wmf added a comment.May 27 2021, 5:05 PM
In T281559#7110133, @santhosh wrote:

The schema need some changes to accommodate anonymous users too. Section translation will support anonymous translation(T278942). Waiting for @nshahquinn-wmf for that.

I've uploaded a patch for that. Now it just needs to be code reviewed and merged; that should happen within a day or two.

nshahquinn-wmf added a comment.EditedMay 27 2021, 5:33 PM
In T281559#7110697, @gerritbot wrote:

Change 685760 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Section translation Eventlogging instrumentation

https://gerrit.wikimedia.org/r/685760

@santhosh I can tell this is a rough initial implementation, but I did notice that you're using the local edit count for user_global_edit_count. I still really want us to use the global edit count. I know this will require some extra network activity, which is not ideal, but it's just a single API call (to the globaluserinfo module) which returns about 1 KB of JSON. I just tested the current SX dashboard, and the total transferred size was about 1,000 KB so this price seems very small.

santhosh added a comment.Jun 1 2021, 5:26 AM

@nshahquinn-wmf Performance issue is not related to how much data the API fetch, but the network dependent API request time, how many such API requests are happening in parallel(which the user just opened the application) that uses up users's bandwidth in parellel.

I get your requirement for global edit count. I will explore ways to have this in application with zero impact on userfacing features.

nshahquinn-wmf added a comment.Jun 1 2021, 9:31 PM
In T281559#7124979, @santhosh wrote:

I get your requirement for global edit count. I will explore ways to have this in application with zero impact on userfacing features.

Thank you, I appreciate that!

gerritbot added a comment.Jun 3 2021, 8:58 AM

Change 697919 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] SX Eventlogging: Fetch global edit count for the user

https://gerrit.wikimedia.org/r/697919

gerritbot added a project: Patch-For-Review.Jun 3 2021, 8:58 AM
gerritbot added a comment.Jun 3 2021, 10:55 AM

Change 697919 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Eventlogging: Fetch global edit count for the user

https://gerrit.wikimedia.org/r/697919

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2021, 11:10 AM
Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 8:18 AM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-July-September) board.
gerritbot added a comment.Jul 13 2021, 1:05 PM

Change 704330 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX Search for article: Add event logging

https://gerrit.wikimedia.org/r/704330

gerritbot added a project: Patch-For-Review.Jul 13 2021, 1:05 PM
ngkountas claimed this task.Jul 13 2021, 1:08 PM
gerritbot added a comment.Jul 15 2021, 6:03 AM

Change 704330 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Search for article: Add event logging

https://gerrit.wikimedia.org/r/704330

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.15; 2021-07-19); removed MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jul 15 2021, 7:00 AM
gerritbot added a comment.Jul 15 2021, 11:13 AM

Change 704770 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXSuggestionList: Add event logging

https://gerrit.wikimedia.org/r/704770

gerritbot added a comment.Jul 16 2021, 5:43 AM

Change 704770 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXSuggestionList: Add event logging

https://gerrit.wikimedia.org/r/704770

Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:32 PM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-October-December) board.
gerritbot added a comment.Oct 27 2021, 4:57 PM

Change 735035 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Move translation start event logging here

https://gerrit.wikimedia.org/r/735035

gerritbot added a comment.Nov 5 2021, 10:26 AM

Change 735035 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Move translation start event logging here

https://gerrit.wikimedia.org/r/735035

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 5 2021, 11:00 AM
gerritbot added a comment.Nov 8 2021, 12:08 PM

Change 737354 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211108

https://gerrit.wikimedia.org/r/737354

gerritbot added a comment.Nov 10 2021, 11:58 AM

Change 737354 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211108

https://gerrit.wikimedia.org/r/737354

Pginer-WMF edited projects, added Language-Team (Language-2022-January-March); removed Language-Team (Language-2021-October-December).Jan 10 2022, 3:23 PM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-January-March) board.
Pginer-WMF changed the task status from Open to In Progress.Jan 11 2022, 4:49 PM
ngkountas added a subtask: T297527: eventgate_validation_error: ''should have required property 'content_translation_session_position'".Jan 17 2022, 11:18 AM
Nikerabbit removed a project: Patch-For-Review.Feb 15 2022, 7:46 AM
Nikerabbit added a project: Epic.Feb 15 2022, 9:20 AM
ngkountas added a comment.Mar 22 2022, 8:48 AM

Events currently being supported:

  • dashboard_open
  • dashboard_discard_suggestion
  • dashboard_search
  • dashboard_translation_start

The rest of the events inside CX event schema will be implemented later. Moving this ticket in our Quarter backlog.

ngkountas moved this task from In Progress to Priority: CX Quality & Maintenance on the Language-Team (Language-2022-January-March) board.Mar 22 2022, 8:49 AM
ngkountas moved this task from Priority: CX Quality & Maintenance to Quarter Backlog on the Language-Team (Language-2022-January-March) board.
gerritbot added a comment.Oct 26 2022, 7:49 AM

Change 849465 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] CX: Add event logging

https://gerrit.wikimedia.org/r/849465

gerritbot added a project: Patch-For-Review.Oct 26 2022, 7:49 AM
gerritbot added a comment.Oct 31 2022, 12:45 PM

Change 849465 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXSuggestionList: Add event logging when suggestions are refreshed

https://gerrit.wikimedia.org/r/849465

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 31 2022, 1:00 PM
gerritbot added a comment.Nov 7 2022, 10:23 AM

Change 853935 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20221107

https://gerrit.wikimedia.org/r/853935

gerritbot added a comment.Nov 7 2022, 6:31 PM

Change 853935 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20221107

https://gerrit.wikimedia.org/r/853935

nshahquinn-wmf unsubscribed.Nov 7 2022, 6:37 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Nov 7 2022, 7:00 PM
gerritbot added a comment.Nov 16 2022, 7:47 AM

Change 857407 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] Add event: editor_segment_add

https://gerrit.wikimedia.org/r/857407

gerritbot added a comment.Dec 6 2022, 8:40 AM

Change 857407 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Add event logging: editor_segment_add

https://gerrit.wikimedia.org/r/857407

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Dec 6 2022, 9:00 AM
gerritbot added a comment.Dec 12 2022, 8:41 AM

Change 867113 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20221212

https://gerrit.wikimedia.org/r/867113

gerritbot added a comment.Dec 12 2022, 2:57 PM

Change 867113 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20221212

https://gerrit.wikimedia.org/r/867113

KCVelaga_WMF closed subtask T297527: eventgate_validation_error: ''should have required property 'content_translation_session_position'" as Resolved.Jan 18 2024, 11:37 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 18 2024, 12:31 PM
Aklapper changed the task status from In Progress to Open.Mar 22 2025, 7:23 AM

Resetting task status from "In Progress" to "Open" as this task has been "in progress" for more than two years.

Nikerabbit closed this task as Resolved.Jun 2 2025, 10:53 AM
Nikerabbit edited projects, added ContentTranslation; removed SectionTranslation.
Nikerabbit moved this task from Needs Triage to Operational issues on the ContentTranslation board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits