Page MenuHomePhabricator

Enhance own user talk page comment notifications with DiscussionTools (display a snippet, link directly to the comment and highlight it)
Closed, ResolvedPublic

Description

Notifications about comment on your user talk page don't link to the comment or include text snippet (unlike normal DiscussionTools comment notifications).

Actually, the highlight does not work. I just tested it on by:

  1. Go the User Talk Page and reply
  2. Navigate away
  3. See the notifications (bell and yellow banner)
  4. Click on bell and notification
  5. Go to reply but there's no highlight here.

Test plan

  • Check the snippet is present in the notification in the popup (F34628044), and that it links directly to the comment and highlights it
  • Check that the link in the orange new message banner (like in T58475) links directly to a comment and highlights it, rather than only linking to the section

Event Timeline

Change 683930 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Override Echo user talk notifs to link directly to the message

https://gerrit.wikimedia.org/r/683930

matmarex renamed this task from Notifications about comment on your user talk page don't link to the comment or include text snippet (unlike normal DiscussionTools comment notifications) to Enhance own user talk page comment notifications with DiscussionTools (display a snippet, link directly to the comment and highlight it).Jun 2 2021, 9:05 PM

Change 705771 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Add test cases for interactions with events generated by base Echo

https://gerrit.wikimedia.org/r/705771

Change 705771 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Test cases for interactions with events generated by base Echo

https://gerrit.wikimedia.org/r/705771

Let's do the User-notice on the parent task T282029, we have several related changes and I think we should announce them together.

Change 683930 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Enhance Echo user talk edit and mention notifications

https://gerrit.wikimedia.org/r/683930