Page MenuHomePhabricator
Create Task
Maniphest T281590

Enhance own user talk page comment notifications with DiscussionTools (display a snippet, link directly to the comment and highlight it)
Closed, ResolvedPublic
Actions

Description

Notifications about comment on your user talk page don't link to the comment or include text snippet (unlike normal DiscussionTools comment notifications).

In T280199#7047878, @iamjessklein wrote:

Actually, the highlight does not work. I just tested it on by:

  1. Go the User Talk Page and reply
  2. Navigate away
  3. See the notifications (bell and yellow banner)
  4. Click on bell and notification
  5. Go to reply but there's no highlight here.

Test plan

  • Check the snippet is present in the notification in the popup (F34628044), and that it links directly to the comment and highlights it
  • Check that the link in the orange new message banner (like in T58475) links directly to a comment and highlights it, rather than only linking to the section

Details

SubjectRepoBranchLines +/-
Enhance Echo user talk edit and mention notificationsmediawiki/extensions/DiscussionToolsmaster+226 -51
Test cases for interactions with events generated by base Echomediawiki/extensions/DiscussionToolsmaster+201 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Apr 30 2021, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2021, 4:51 PM
matmarex added a parent task: T281471: Topic Subscription Prototype: Highlight thread after following a notification .Apr 30 2021, 4:52 PM
gerritbot added a comment.Apr 30 2021, 4:53 PM

Change 683930 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Override Echo user talk notifs to link directly to the message

https://gerrit.wikimedia.org/r/683930

gerritbot added a project: Patch-For-Review.Apr 30 2021, 4:53 PM
matmarex updated the task description. (Show Details)Apr 30 2021, 4:57 PM
matmarex mentioned this in T280199: Implement a way for test comments to be posted automatically.
matmarex added a subscriber: • iamjessklein.
matmarex claimed this task.Apr 30 2021, 5:15 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
• ppelberg added a parent task: T282029: Take people to the precise location of the talk page activity they are being notified about.May 5 2021, 5:23 PM
• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.May 6 2021, 3:12 PM
• LZaman mentioned this in T274188: Offer manual topic subscriptions as a Beta Feature at partner wikis.Jun 1 2021, 7:42 PM
matmarex renamed this task from Notifications about comment on your user talk page don't link to the comment or include text snippet (unlike normal DiscussionTools comment notifications) to Enhance own user talk page comment notifications with DiscussionTools (display a snippet, link directly to the comment and highlight it).Jun 2 2021, 9:05 PM
matmarex removed a parent task: T281471: Topic Subscription Prototype: Highlight thread after following a notification .Jun 2 2021, 9:07 PM
matmarex mentioned this in T282029: Take people to the precise location of the talk page activity they are being notified about.Jun 2 2021, 9:11 PM
matmarex mentioned this in T253082: Enhance mention notifications with DiscussionTools (link directly to the comment and highlight it).Jun 2 2021, 10:18 PM
gerritbot added a comment.Jul 20 2021, 10:41 PM

Change 705771 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Add test cases for interactions with events generated by base Echo

https://gerrit.wikimedia.org/r/705771

gerritbot added a comment.Aug 3 2021, 11:18 PM

Change 705771 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Test cases for interactions with events generated by base Echo

https://gerrit.wikimedia.org/r/705771

matmarex added a subtask: T273072: Enable DiscussionTools page transformations (DOM modification) for all users.Aug 6 2021, 7:20 PM
• ppelberg mentioned this in T58475: Echo: The "You have new messages" link should go to a diff and/or subsection of the user's talk page where the talk page resides.Sep 1 2021, 12:14 AM
matmarex updated the task description. (Show Details)Sep 1 2021, 4:31 PM
• Whatamidoing-WMF added a project: User-notice.Sep 9 2021, 8:19 PM
Quiddity moved this task from To Triage to Not ready to announce on the User-notice board.Sep 9 2021, 8:35 PM
matmarex removed a project: User-notice.Sep 10 2021, 4:39 PM

Let's do the User-notice on the parent task T282029, we have several related changes and I think we should announce them together.

• LZaman mentioned this in T273072: Enable DiscussionTools page transformations (DOM modification) for all users.Sep 15 2021, 5:04 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 24 2021, 2:13 AM
DLynch added a project: Editing QA.
gerritbot added a comment.Sep 24 2021, 2:17 AM

Change 683930 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Enhance Echo user talk edit and mention notifications

https://gerrit.wikimedia.org/r/683930

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2021, 3:10 AM
• ppelberg moved this task from Inbox to High Priority on the Editing QA board.Sep 24 2021, 4:04 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 27 2021, 6:14 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
• ppelberg closed this task as Resolved.Sep 27 2021, 7:38 PM
• ppelberg closed subtask T273072: Enable DiscussionTools page transformations (DOM modification) for all users as Resolved.Sep 29 2021, 5:17 AM
VPuffetMichel mentioned this in T296018: Android team cannot associate a talk page notification with a specific section anymore.Nov 18 2021, 7:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL