Page MenuHomePhabricator
Create Task
Maniphest T281594

Remove Edit source link when in suggestion mode
Closed, ResolvedPublic
Actions

Description

Until edit mode toggle T269653: Add a link: edit mode toggle (machine suggestions & visual) is done, we want to remove entry points for the user to switch the editor interface. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/683557 removes the edit mode switch tool from the toolbar, but the "Edit source" tab can remain, so we should remove that.

Details

SubjectRepoBranchLines +/-
AddLink: Remove edit source tab if presentmediawiki/extensions/GrowthExperimentsmaster+10 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Apr 30 2021, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2021, 6:07 PM
kostajh claimed this task.Apr 30 2021, 6:07 PM
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Apr 30 2021, 6:11 PM

Change 683941 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Remove edit source tab if present

https://gerrit.wikimedia.org/r/683941

gerritbot added a project: Patch-For-Review.Apr 30 2021, 6:11 PM
kostajh moved this task from Backlog to April 26 - April 30 on the Add-Link board.Apr 30 2021, 6:11 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh triaged this task as Medium priority.May 1 2021, 7:36 PM
gerritbot added a comment.May 2 2021, 10:07 PM

Change 683941 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Remove edit source tab if present

https://gerrit.wikimedia.org/r/683941

kostajh moved this task from April 26 - April 30 to Done / QA on the Add-Link board.May 2 2021, 10:08 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot removed a project: Patch-For-Review.May 2 2021, 10:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 2 2021, 11:00 PM
RHo mentioned this in T269638: Add a link: Suggestions mode.May 3 2021, 6:52 PM
Etonkovidova closed this task as Resolved.May 13 2021, 1:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits