Page MenuHomePhabricator

Special:Nearby not showing labels
Closed, ResolvedPublicBUG REPORT

Description

Problem:
Special:Nearby on Wikidata does not show labels for the Items listed around me even though they have labels in my interface language. It only shows me their Q-IDs.

https://www.wikidata.org/wiki/Special:Nearby

Screenshots/mockups:

image.png (799×470 px, 141 KB)

Acceptance criteria:

  • Labels are shown on Special:Nearby in my interface language or a fallback language if available.
  • Only if no label is available in my user interface language or a fallback language is the Q-ID shown.

Notes:

  • Likely broke at some point in 2020 or 2021
  • Labels were introduced in T115014
  • It previously broke in T141175

Event Timeline

Change 697671 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[operations/mediawiki-config@master] Fix pageterms API call for Special:Nearby in Wikidata

https://gerrit.wikimedia.org/r/697671

Change 697671 merged by jenkins-bot:

[operations/mediawiki-config@master] Fix pageterms API call for Special:Nearby in Wikidata

https://gerrit.wikimedia.org/r/697671

FYI: Heads up in case you are not aware, Special:Nearby provided by MobileFrontend is on the way out.

It will be replaced by https://github.com/wikimedia/mediawiki-extensions-NearbyPages which is currently blocked on security review.

Not sure what happened here, but would be great if somebody checked if the new extension has this problem, otherwise this issue will soon resurface!

Change 697678 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MobileFrontend@master] Accept entityterms as value of terms too

https://gerrit.wikimedia.org/r/697678

Thanks for the note. I'll check that soon, make sure to coordinate before deploying that to Wikidata please. The bug actually affects search as well so I rather fix it with the given patch above ^

We also plan to migrate search in the next 3-6 months so that code also has a shelf life. See T28247. There should be tasks for all the Wikibase specific issues I know of. One of the reasons we're trying to move away from this code, is we're doing a bad job of keeping it maintained given the multiple search-like UIs we have across our products.

Mentioned in SAL (#wikimedia-operations) [2021-06-02T05:31:32Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:697671|Fix pageterms API call for Special:Nearby in Wikidata (T281639)]] (duration: 00m 56s) [REPLAY FROM 2021-06-01 21:44:06]

Change 697678 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Accept entityterms as value of terms too

https://gerrit.wikimedia.org/r/697678

so it's a bit hard to backport this. I'll let it slide through train next week

Good news.

BTW it would be helpful to display the description too.

Let's tackle that in its successor

@Ladsgroup @Esc3300 please no new features on the legacy version of Nearby while we gear up for deployment of the new Vue.js built version https://mediawiki.org/wiki/Extension:NearbyPages and decommission this one.

That extension has been tested against Wikidata and addresses that problem.

I don't want to add more code to MobileFrontend as that's just more code we need to tear down afterwards.

Just to be clear, that's exactly what I said in T281639#7134622 :D

haha :) Misread "successor" as meaning a successor patch :)