Change 684121 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[wikimedia/fundraising/crm/civicrm-buildkit@master] Set wmff CIVI_SITE_KEY for Docker dev setup

https://gerrit.wikimedia.org/r/684121

Change 684122 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[wikimedia/fundraising/dev@master] Set static CIVI_SITE_KEY for Civiproxy

https://gerrit.wikimedia.org/r/684122

Change 684006 had a related patch set uploaded (by AndyRussG; author: Ejegg):

[wikimedia/fundraising/dev@master] WIP set admin API key

https://gerrit.wikimedia.org/r/684006

Change 684003 had a related patch set uploaded (by AndyRussG; author: Ejegg):

[wikimedia/fundraising/crm/civicrm-buildkit@master] WMFF: sync all drupal users to contacts

https://gerrit.wikimedia.org/r/684003

Hi @AndyRussG. Appreciate you writing some of this up for me and giving this your attention over the weekend. The first two tasks do feel like good improvements but I wonder if the others are as much of a priority and need changing at all? I don't envisage us changing the port of civiproxy (as it means then changing the values in the config) or the service name for the ServiceAlias, as these are pretty tightly coupled to the local environment install of CiviCRM. I mean we could, but it feels like the benefits vs the work needed don't stack up which is why I left it out and would be happy to discuss it with you if you feel otherwise. It would have been better to discuss these issues on the gerrit patch before creating tasks I feel. Same again with the rsyslog config, if that is misconfigured it would have been good to know before merging the patch.

In T281651#7057497, @jgleeson wrote:

Hi @AndyRussG. Appreciate you writing some of this up for me and giving this your attention over the weekend. The first two tasks do feel like good improvements but I wonder if the others are as much of a priority and need changing at all? I don' envisage us changing the port of civiproxy (as it means then changing the values in the config) or the service name for the ServiceAlias, as these are pretty tightly coupled to the local environment install of CiviCRM. I mean we could, but it feels like the benefits vs the work needed don't stack up which is why I left it out and would be happy to discuss it with you if you feel otherwise. It would have been better to discuss these issues on the gerrit patch before creating tasks I feel. Same again with the rsyslog config, if that is misconfigured it would have been good to know before merging the patch.

Hi, thanks! Just to note, indeed the first bits did seem useful for speeding up our work, but the rest of this task, if I understand correctly, is now low priority? Also, I guess just to clarify, I'd say rsyslog is not misconfigured, just could be configured slightly differently. Sorry I wasn't clear.

I did ask the team in a meeting about merging the initial CiviProxy patch as it was, and it was agreed that we should do so. I think now this task could just be a placeholder/space for notes which we can discuss later as needed? How does that sound?

Yeah, agreed that it made sense to merge it as it was but I feel like the other follow-up tasks would have been better discussed and agreed on the patch. I think we can still add review feedback on commits that are +2'd right?

It's easier to keep track of the specific bits of the code that you have feedback on if we keep it on Gerrit, for when we come to do the work.

Change 684003 merged by Ejegg:

[wikimedia/fundraising/crm/civicrm-buildkit@master] WMFF: sync drupal users and set API key for Docker dev setup

https://gerrit.wikimedia.org/r/684003

Change 684121 merged by Ejegg:

[wikimedia/fundraising/crm/civicrm-buildkit@master] WMFF: Static CIVI_SITE_KEY for Docker dev setup

https://gerrit.wikimedia.org/r/684121

Change 684006 merged by Ejegg:

[wikimedia/fundraising/dev@master] Set Civicrm API key for Civiproxy

https://gerrit.wikimedia.org/r/684006

Change 684122 merged by Ejegg:

[wikimedia/fundraising/dev@master] Set static CIVI_SITE_KEY for Civiproxy

https://gerrit.wikimedia.org/r/684122