TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface UserIdentity, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.37.0-wmf.3
reqId: 6c0d6e740486c73640aab286
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface MediaWiki\User\UserIdentity, null given, called in /srv/mediawiki/php-1.37.0-wmf.3/extensions/Grow

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/CacheDecorator.php(49)
#0 /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(170): GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator->suggest(NULL, array, array, integer, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.3/maintenance/doMaintenance.php(112): GrowthExperiments\Maintenance\RefreshLinkRecommendations->execute()
#2 /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(501): require_once(string)
#3 /srv/mediawiki/multiversion/MWScript.php(116): require_once(string)
#4 {main}

Impact

New link recommendation tasks are not generated. Link recommendations are in stealth mode so no user impact yet.

Notes

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	RefreshLinkRecommendations: force getting a system user if needed	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Production Excellence #32: May 2021
T278710: Add a link: production deployment
Mentioned Here: T278710: Add a link: production deployment

Event Timeline

Tgr created this task.May 3 2021, 12:44 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 3 2021, 12:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Looks like Maintenance script is not a system user on cswiki so $this->searchUser = User::newSystemUser( 'Maintenance script' ); ends up setting it to null.

Change 684386 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] RefreshLinkRecommendations: force getting a system user if needed

https://gerrit.wikimedia.org/r/684386

gerritbot added a project: Patch-For-Review.May 3 2021, 12:51 PM

Tgr claimed this task.May 3 2021, 12:51 PM

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Mentioned in SAL (#wikimedia-operations) [2021-05-03T13:10:47Z] <Urbanecm> Run User::newSystemUser( 'Maintenance script', [ 'steal' => true ] ) on cswiki to make the user a proper system user (T281703)

Change 684386 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] RefreshLinkRecommendations: force getting a system user if needed

https://gerrit.wikimedia.org/r/684386

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 3 2021, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 2:10 PM

kostajh triaged this task as High priority.May 3 2021, 2:43 PM

kostajh moved this task from Backlog to Done / QA on the Add-Link-Structured-Task board.

kostajh reopened this task as Open.May 4 2021, 10:47 AM

kostajh closed this task as a duplicate of T281786: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface MediaWiki\User\UserIdentity, null given, called in /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php on line 170.

kostajh merged a task: T281786: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface MediaWiki\User\UserIdentity, null given, called in /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php on line 170.

kostajh added a subscriber: • mewoph.

Mentioned in SAL (#wikimedia-operations) [2021-05-04T11:31:40Z] <Urbanecm> Run User::newSystemUser( 'Maintenance script', [ 'steal' => true ] ); on arwiki, bnwiki, viwiki (T278710, T281703)

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 4 2021, 8:21 PM

Krinkle renamed this task from TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface MediaWiki\User\UserIdentity, null given, called in /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php on line 170 to TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface UserIdentity, null given.May 6 2021, 11:12 PM

Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 7 2021, 11:55 PM

Etonkovidova closed this task as Resolved.May 18 2021, 1:53 AM

Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM