Page MenuHomePhabricator

Remove calls to WikibaseRepo::getUserLanguage from the MessageParameterFormatter Service wiring
Closed, ResolvedPublic

Description

Currently, the MessageParameterFormatter defined in WikibaseRepo.ServiceWiring.php calls the deprecated UserLanguage service from WikibaseRepo. In order to retire this service, we will need to find a way to obtain the language in a more appropriate way, possibly through RequestContext::getLanguage().

Acceptance Criteria

  • We should no longer be making calls to deprecated user language service in MessageParameterFormatter

Event Timeline

Lucas_Werkmeister_WMDE renamed this task from Remove calls to WikibaseRepo::getUserLanguage from the MessageParamterFormatter Service wiring to Remove calls to WikibaseRepo::getUserLanguage from the MessageParameterFormatter Service wiring.May 3 2021, 3:52 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Change #1140144 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove call to WikibaseRepo::getUserLanguage from service wiring

https://gerrit.wikimedia.org/r/1140144

Change #1140165 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Make test setup load service once before test runs

https://gerrit.wikimedia.org/r/1140165

Change #1140167 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove the UserLanguage service from Wikibase

https://gerrit.wikimedia.org/r/1140167

Change #1140185 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Unstub $wgLang explicitly instead of relying on service

https://gerrit.wikimedia.org/r/1140185

Change #1140165 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make test setup load service once before test runs

https://gerrit.wikimedia.org/r/1140165

Change #1140185 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Unstub $wgLang explicitly instead of relying on service

https://gerrit.wikimedia.org/r/1140185

Change #1140144 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove call to WikibaseRepo::getUserLanguage from service wiring

https://gerrit.wikimedia.org/r/1140144