Page MenuHomePhabricator
Create Task
Maniphest T281720

Remove calls to WikibaseRepo::getUserLanguage from the MessageParameterFormatter Service wiring
Closed, ResolvedPublic
Actions

Description

Currently, the MessageParameterFormatter defined in WikibaseRepo.ServiceWiring.php calls the deprecated UserLanguage service from WikibaseRepo. In order to retire this service, we will need to find a way to obtain the language in a more appropriate way, possibly through RequestContext::getLanguage().

Acceptance Criteria

  • We should no longer be making calls to deprecated user language service in MessageParameterFormatter

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove call to WikibaseRepo::getUserLanguage from service wiringmediawiki/extensions/Wikibasemaster+40 -49
Unstub $wgLang explicitly instead of relying on servicemediawiki/extensions/Wikibasemaster+2 -6
Make test setup load service once before test runsmediawiki/extensions/Wikibasemaster+6 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.May 3 2021, 2:41 PM
ItamarWMDE removed projects: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Wikidata-Campsite.May 3 2021, 3:47 PM
Lucas_Werkmeister_WMDE renamed this task from Remove calls to WikibaseRepo::getUserLanguage from the MessageParamterFormatter Service wiring to Remove calls to WikibaseRepo::getUserLanguage from the MessageParameterFormatter Service wiring.May 3 2021, 3:52 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Addshore moved this task from Inbox to Hike Leftovers on the [DEPRECATED] wdwb-tech board.May 3 2021, 4:33 PM
Addshore moved this task from Hike Leftovers to Subtasks on the [DEPRECATED] wdwb-tech board.Jun 28 2021, 3:16 PM
Arian_Bozorg updated the task description. (Show Details)Apr 16 2025, 9:13 AM
karapayneWMDE added a project: Wikidata-Omega.Apr 16 2025, 9:26 AM
karapayneWMDE moved this task from Incoming to The Backlog on the Wikidata-Omega board.
ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.Apr 30 2025, 9:20 AM
ArthurTaylor edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.
ArthurTaylor moved this task from The Board to The Backlog on the Wikidata-Omega board.
ArthurTaylor edited projects, added: Wikidata-Omega; removed: Wikidata-Omega (The Board).
ArthurTaylor claimed this task.Apr 30 2025, 9:53 AM
ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Apr 30 2025, 10:04 AM

Change #1140144 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove call to WikibaseRepo::getUserLanguage from service wiring

https://gerrit.wikimedia.org/r/1140144

gerritbot added a project: Patch-For-Review.Apr 30 2025, 10:04 AM
gerritbot added a comment.Apr 30 2025, 11:52 AM

Change #1140165 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Make test setup load service once before test runs

https://gerrit.wikimedia.org/r/1140165

gerritbot added a comment.Apr 30 2025, 11:57 AM

Change #1140167 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove the UserLanguage service from Wikibase

https://gerrit.wikimedia.org/r/1140167

ArthurTaylor removed ArthurTaylor as the assignee of this task.Apr 30 2025, 12:23 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor subscribed.
gerritbot added a comment.Apr 30 2025, 2:07 PM

Change #1140185 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Unstub $wgLang explicitly instead of relying on service

https://gerrit.wikimedia.org/r/1140185

Lucas_Werkmeister_WMDE claimed this task.Apr 30 2025, 2:10 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Apr 30 2025, 9:59 PM

Change #1140165 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make test setup load service once before test runs

https://gerrit.wikimedia.org/r/1140165

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).Apr 30 2025, 10:00 PM
gerritbot added a comment.May 1 2025, 2:28 PM

Change #1140185 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Unstub $wgLang explicitly instead of relying on service

https://gerrit.wikimedia.org/r/1140185

gerritbot added a comment.May 15 2025, 10:00 AM

Change #1140144 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove call to WikibaseRepo::getUserLanguage from service wiring

https://gerrit.wikimedia.org/r/1140144

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 15 2025, 10:00 AM
ArthurTaylor removed Lucas_Werkmeister_WMDE as the assignee of this task.May 15 2025, 10:34 AM
ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.
ArthurTaylor added a subscriber: Lucas_Werkmeister_WMDE.
karapayneWMDE closed this task as Resolved.May 15 2025, 2:21 PM
karapayneWMDE claimed this task.
karapayneWMDE moved this task from Ready for Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
karapayneWMDE edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2025 Q2 on the Wikidata-Omega (Completed Tasks) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits