Page MenuHomePhabricator

Rename GrowthExperiments default user variant to 'control'
Closed, ResolvedPublic

Description

The default option for GrowthExperiments' A/B testing system is named 'null' (as in "null hypothesis"), which is a poor choice as it can be mistaken to the special null value most programming languages have. This leads to all kinds of confusing situations, e.g. ge.utils.setUserVariant(null) and ge.utils.setUserVariant('null') do similar but not identical things.

Changing the name will be harder once the A/B test starts so let's change it before then, e.g. to 'control' (as in "control group").

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh triaged this task as Medium priority.

Change 684798 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Rename variant control group to 'control'

https://gerrit.wikimedia.org/r/684798

Change 684799 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] GrowthExperiments: Rename control variant to 'control'

https://gerrit.wikimedia.org/r/684799

Change 684829 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] Rename variant control group to 'control'

https://gerrit.wikimedia.org/r/684829

Change 684830 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.4] Rename variant control group to 'control'

https://gerrit.wikimedia.org/r/684830

Change 684798 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Rename variant control group to 'control'

https://gerrit.wikimedia.org/r/684798

Change 684857 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Temporarily re-add 'null' control group

https://gerrit.wikimedia.org/r/684857

Change 684829 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] Rename variant control group to 'control'

https://gerrit.wikimedia.org/r/684829

Change 684832 had a related patch set uploaded (by Urbanecm; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] Temporarily re-add 'null' control group

https://gerrit.wikimedia.org/r/684832

Change 684830 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.4] Rename variant control group to 'control'

https://gerrit.wikimedia.org/r/684830

Change 684832 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] Temporarily re-add 'null' control group

https://gerrit.wikimedia.org/r/684832

Change 684799 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Rename control variant to 'control'

https://gerrit.wikimedia.org/r/684799

Change 684878 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] GrowthExperiments: Set linkrecommendation variant to 0

https://gerrit.wikimedia.org/r/684878

Change 684878 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Set linkrecommendation variant to 0

https://gerrit.wikimedia.org/r/684878

Mentioned in SAL (#wikimedia-operations) [2021-05-04T12:20:49Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.3/extensions/GrowthExperiments/: 8f938c2: c8c07ab: GrowthExperiments backports (T281727) (duration: 00m 59s)

Mentioned in SAL (#wikimedia-operations) [2021-05-04T12:22:48Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 683b876: 5763630: GrowthExperiments: Rename control variant to control, GrowthExperiments: Set linkrecommendation variant to 0 (T281727) (duration: 00m 58s)

Change 684857 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] Temporarily re-add 'null' control group

Reason:

this doesn't need to be merged in master (was only needed to let us change config safely), abandoning.

https://gerrit.wikimedia.org/r/684857