Problems with hidden tags on enhanced Special:RecentChanges
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	May 3 2021, 5:59 PM

Description

There are few issues with hidden tags (e.g. discussiontools-source-enhanced)

You can't search for them, or event manually type them in to the search box on RecentChanges
You can access a list of associated changes via Special:Tags, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:Tags will take me to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChanges&tagfilter=discussiontools-source-enhanced, however:
- As soon as you land on Special:RecentChanges, the URL gets rewritten, removing the tagfilter parameter

Details

Subject	Repo	Branch	Lines +/-
ChangeTags: Fix adding CSS classes for hidden tags	mediawiki/core	REL1_37	+1 -1
ChangeTags: Fix adding CSS classes for hidden tags	mediawiki/core	REL1_35	+1 -1
ChangeTags: Fix adding CSS classes for hidden tags	mediawiki/core	master	+1 -1
ChangeTags: Add CSS classes to rows for hidden tags too	mediawiki/core	master	+1 -1
Mark hidden tags on Special:Tags and show in RCFilters	mediawiki/core	master	+14 -7

Customize query in gerrit

Related Objects

Mentioned In: T262107: Create a hidden revision tag for talk page comments
T279157: Create a hidden change tag for edits made with the new source mode
Mentioned Here: T249038: Tag edits made in the WikiEditor (2010 wikitext editor)

Event Timeline

Esanders created this task.May 3 2021, 5:59 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 3 2021, 5:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Esanders mentioned this in T279157: Create a hidden change tag for edits made with the new source mode.May 4 2021, 11:43 AM

kostajh moved this task from Inbox to Triaged on the Growth-Team board.May 4 2021, 1:42 PM

kostajh triaged this task as Medium priority.May 4 2021, 1:46 PM

Change 715834 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Mark hidden tags on Special:Tags and show in RCFilters

https://gerrit.wikimedia.org/r/715834

gerritbot added a project: Patch-For-Review.Sep 1 2021, 12:34 AM

matmarex subscribed.Sep 1 2021, 12:34 AM

DannyS712 awarded a token.Sep 4 2021, 4:57 AM

DannyS712 subscribed.

matmarex added a project: Editing-team (Kanban Board).Sep 8 2021, 9:21 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

matmarex mentioned this in T262107: Create a hidden revision tag for talk page comments.Sep 9 2021, 3:42 PM

Note: this patch being merged would enable us to do things like filtering recent changes for new comments newcomers are adding to talk pages. Right now, it's not possible to filter/operate on the raw list of edits that pass through the recently-added discussiontools-added-comment filter.

• ppelberg moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Sep 9 2021, 5:48 PM

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 9 2021, 8:19 PM

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

@matmarex does this need a User-notice?

Change 715834 merged by jenkins-bot:

[mediawiki/core@master] Mark hidden tags on Special:Tags and show in RCFilters

https://gerrit.wikimedia.org/r/715834

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 10 2021, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 10 2021, 9:11 AM

In T281741#7344041, @kostajh wrote:

@matmarex does this need a User-notice?

I think it's not needed, it's a rather small change?

matmarex added a project: Editing QA.Sep 10 2021, 4:47 PM

Checked in betalabs - the issues listed in the task descriptions are done.

You can't search for them, or event manually type them in to the search box on RecentChanges

The hidden tags are present on RC/Watchlist filters:

Screen Shot 2021-09-13 at 2.12.02 PM.png (536×1 px, 159 KB)

You can access a list of associated changes via Special:Tags, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:Tags will take me to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChanges&tagfilter=discussiontools-source-enhanced, however:

As soon as you land on Special:RecentChanges, the URL gets rewritten, removing the tagfilter parameter

The url maintains the tagfilter parameter: e.g. this is the link from Special:Tags page: https://en.wikipedia.beta.wmflabs.org/w/index.php?tagfilter=discussiontools-source-enhanced&limit=50&days=7&title=Special:RecentChanges&urlversion=2

However,the highlighting cannot be applied to hidden tags. @ppelberg, @matmarex - should it be fixed? Let me know if a separate ticket is needed.

Screen Shot 2021-09-13 at 2.18.48 PM.png (472×1 px, 114 KB)

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 13 2021, 9:43 PM

Oh, that was supposed to work! I swear I thought I tested it. Thank you for noticing.

Change 721063 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ChangeTags: Add CSS classes to rows for hidden tags too

https://gerrit.wikimedia.org/r/721063

gerritbot added a project: Patch-For-Review.Sep 14 2021, 8:52 PM

matmarex moved this task from QA to Code Review on the Editing-team (Kanban Board) board.Sep 14 2021, 8:53 PM

kostajh moved this task from Test in Production | Watching to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 16 2021, 12:07 PM

Change 721063 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Add CSS classes to rows for hidden tags too

https://gerrit.wikimedia.org/r/721063

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 16 2021, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2021, 1:11 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 16 2021, 4:29 PM

matmarex removed a project: Editing QA.Sep 16 2021, 5:16 PM

matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

Checked in betalabs - the highlight for hidden tags works now.

In T281741#7360660, @Etonkovidova wrote:

Checked in betalabs - the highlight for hidden tags works now.

Wonderful; we appreciate you reviewing this, @Etonkovidova !

I realized today (while trying to review the tagging for T249038) that the issue with highlighting that @Etonkovidova reported isn't properly fixed. Highlighting of hidden tags works when the edit has other non-hidden tags as well, but not when it's the only tag.

Change 748136 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ChangeTags: Fix adding CSS classes for hidden tags

https://gerrit.wikimedia.org/r/748136

gerritbot added a project: Patch-For-Review.Dec 17 2021, 2:46 PM

Change 748136 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Fix adding CSS classes for hidden tags

https://gerrit.wikimedia.org/r/748136

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.16; 2022-01-03); removed MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Dec 17 2021, 5:00 PM

matmarex moved this task from Test in Production | Watching to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 17 2021, 5:03 PM

matmarex edited projects, added Editing QA; removed Patch-For-Review.

(Oops, wrong QA column…)

• ppelberg removed • ppelberg as the assignee of this task.Dec 22 2021, 5:11 PM

Checked on betalabs - the edits with one hidden tag gets properly highlighted, e.g. the following edit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Mavetuna58z&oldid=531845 has only one hidden tag discussiontools-added-comment, will be correctly highlighted on RC.

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 23 2021, 10:38 PM

Checked in wmf.18 - all seems to be working as expected.

This looks good to me

Screenshot 2022-01-19 at 03.45.35.png (912×2 px, 286 KB)

The tagfilter parameter is intact on Special:RecentChanges as well

EAkinloose edited projects, added Verified; removed Editing QA.Jan 19 2022, 2:49 AM

Change 809952 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):

[mediawiki/core@REL1_37] ChangeTags: Fix adding CSS classes for hidden tags

https://gerrit.wikimedia.org/r/809952

Change 809953 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):

[mediawiki/core@REL1_35] ChangeTags: Fix adding CSS classes for hidden tags

https://gerrit.wikimedia.org/r/809953

Change 809953 merged by jenkins-bot: