Page MenuHomePhabricator

Problems with hidden tags on enhanced Special:RecentChanges
Closed, ResolvedPublic

Description

There are few issues with hidden tags (e.g. discussiontools-source-enhanced)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh triaged this task as Medium priority.May 4 2021, 1:46 PM

Change 715834 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Mark hidden tags on Special:Tags and show in RCFilters

https://gerrit.wikimedia.org/r/715834

Note: this patch being merged would enable us to do things like filtering recent changes for new comments newcomers are adding to talk pages. Right now, it's not possible to filter/operate on the raw list of edits that pass through the recently-added discussiontools-added-comment filter.

Change 715834 merged by jenkins-bot:

[mediawiki/core@master] Mark hidden tags on Special:Tags and show in RCFilters

https://gerrit.wikimedia.org/r/715834

@matmarex does this need a User-notice?

I think it's not needed, it's a rather small change?

Checked in betalabs - the issues listed in the task descriptions are done.

  • You can't search for them, or event manually type them in to the search box on RecentChanges

The hidden tags are present on RC/Watchlist filters:

Screen Shot 2021-09-13 at 2.12.02 PM.png (536×1 px, 159 KB)

The url maintains the tagfilter parameter: e.g. this is the link from Special:Tags page: https://en.wikipedia.beta.wmflabs.org/w/index.php?tagfilter=discussiontools-source-enhanced&limit=50&days=7&title=Special:RecentChanges&urlversion=2

However,the highlighting cannot be applied to hidden tags. @ppelberg, @matmarex - should it be fixed? Let me know if a separate ticket is needed.

Screen Shot 2021-09-13 at 2.18.48 PM.png (472×1 px, 114 KB)

Oh, that was supposed to work! I swear I thought I tested it. Thank you for noticing.

Change 721063 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ChangeTags: Add CSS classes to rows for hidden tags too

https://gerrit.wikimedia.org/r/721063

Change 721063 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Add CSS classes to rows for hidden tags too

https://gerrit.wikimedia.org/r/721063

Checked in betalabs - the highlight for hidden tags works now.

ppelberg claimed this task.

Checked in betalabs - the highlight for hidden tags works now.

Wonderful; we appreciate you reviewing this, @Etonkovidova !