RecommendedLinkToolBarDialog class inherits from ve.ui.ToolbarDialog and uses custom position values: below for mobile and inline for desktop. These supported values should be updated and documented in VE as well.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Catrope | T261398 Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach | |||
| Resolved | MMiller_WMF | T252822 [EPIC] Growth: "add a link" structured task 1.0 | |||
| Resolved | • mewoph | T267706 Add a link in VE: Use a permanent context instead of VE's built-in context | |||
| Resolved | • mewoph | T281788 Add a link in VE: Include "below" and "inline" position values for ve.ui.ToolbarDialog upstream |
Event Timeline
Comment Actions
Change 691284 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[VisualEditor/VisualEditor@master] Add positions 'inline' and 'below' to ve.ui.ToolbarDialog
Comment Actions
Change 691284 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Add positions 'inline' and 'below' to ve.ui.ToolbarDialog
Comment Actions
Change 694632 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bc819fdc6)
Comment Actions
Change 694632 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bc819fdc6)